[Merged by Bors] - refactor(algebra/group_power, data/nat/basic): remove redundant lemmas #4243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwbarton
added
the
awaiting-review
|
Did you change the code in |
|
LGTM too. The broken test is that there are some |
Essentially just moved, there were (ironically) a couple small changes to use |
|
bors merge |
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Sep 25, 2020
#4243) This removes lemmas about `pow` on `nat` which are redundant with more general versions in the root namespace. One notable removal is `nat.pow_succ`; use `pow_succ'` instead. In order that the general versions are available already in `data.nat.basic`, many lemmas from `algebra.group_power.lemmas` have been moved to `algebra.group_power.basic` (basically as many as possible without adding imports).
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes lemmas about
powonnatwhich are redundantwith more general versions in the root namespace.
One notable removal is
nat.pow_succ; usepow_succ'instead.In order that the general versions are available already in
data.nat.basic,many lemmas from
algebra.group_power.lemmashave been moved toalgebra.group_power.basic(basically as many as possible without adding imports).To reviewers: This might be easier to understand one commit at a time.
Each commit leaves the tree in a state that should build (though that might
no longer be true if the branch gets rebased).