[Merged by Bors] - refactor(data/nat/basic): review API of nat.find_greatest
#4274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion Also prove that a `topological_semiring` is a `topological_semimodule`.
…her PR" This reverts commit c218a60.
Fix compile
jcommelin
approved these changes
Sep 26, 2020
|
bors merge |
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Sep 28, 2020
Other changes: * add `nat.find_eq_iff`; * use weaker assumptions in `measurable_to_encodable` and `measurable_to_nat`; * add `measurable_find`.
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
nat.find_greatestnat.find_greatest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Other changes:
nat.find_eq_iff;measurable_to_encodableandmeasurable_to_nat;measurable_find.After #4199
nat.find_greatestis no longer used by any "real"theorem. This API review was done as a part of an earlier version
of #4199. Another option is to remove
nat.find_greatest.