[Merged by Bors] - fix(data/list/basic): Ensure that ball_cons actually works as a simp lemma #4281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l_cons` are synonyms
…lemma The LHS of ball_cons (aka forall_mem_cons) is not in simp-normal form, as `mem_cons_iff` rewrites it. This adds a new simp lemma which is the form that `mem_cons_iff` rewrites it to.
eric-wieser
added
the
blocked-by-other-PR
eric-wieser
changed the title
|
I think we don't need |
digama0
changed the title
|
I agree, although there are a few places that refer to it directly by name. If CI passes on this one, I'll come back and:
I'm expecting the worst given the behavior of lemmas in #4143, which is a similar sort of change. |
github-actions
bot
added
the
merge-conflict
eric-wieser
removed
the
blocked-by-other-PR
github-actions
bot
removed
the
merge-conflict
eric-wieser
changed the title
eric-wieser
added
the
awaiting-review
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Sep 28, 2020
…lemma (#4281) The LHS of the simp lemma `list.ball_cons` (aka `list.forall_mem_cons`) is not in simp-normal form, as `list.mem_cons_iff` rewrites it. This adds a new simp lemma which is the form that `list.mem_cons_iff` rewrites it to.
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The LHS of the simp lemma
list.ball_cons(akalist.forall_mem_cons) is not in simp-normal form, aslist.mem_cons_iffrewrites it.This adds a new simp lemma which is the form that
list.mem_cons_iffrewrites it to.https://leanprover.zulipchat.com/#narrow/stream/113488-general/topic/Case-bashing.20.60list.2Epairwise.60.20with.20.60simp.60/near/211276203
First commit is #4279