Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore(data/option): swap sides in ne_none_iff_exists #4285

Closed
wants to merge 1 commit into from

Conversation

urkud
Copy link
Member

@urkud urkud commented Sep 27, 2020

  • swap lhs and rhs of the equality in option.ne_none_iff_exists; the new order matches, e.g., the definition of set.range and can_lift.prf;
  • the same in with_one.ne_one_iff_exists and with_zero.ne_zero_iff_exists;
  • remove option.ne_none_iff_exists';
  • restore the original option.ne_none_iff_exists as option.ne_none_iff_exists'

@urkud urkud added the awaiting-review The author would like community review of the PR label Sep 27, 2020
@fpvandoorn
Copy link
Member

LGTM

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Sep 27, 2020
bors bot pushed a commit that referenced this pull request Sep 27, 2020
* swap lhs and rhs of the equality in `option.ne_none_iff_exists`; the new order matches, e.g., the definition of `set.range` and `can_lift.prf`;
* the same in `with_one.ne_one_iff_exists` and `with_zero.ne_zero_iff_exists`;
* remove `option.ne_none_iff_exists'`;
* restore the original `option.ne_none_iff_exists` as `option.ne_none_iff_exists'`
@bors
Copy link

bors bot commented Sep 27, 2020

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title chore(data/option): swap sides in ne_none_iff_exists [Merged by Bors] - chore(data/option): swap sides in ne_none_iff_exists Sep 27, 2020
@bors bors bot closed this Sep 27, 2020
@bors bors bot deleted the iff_exists_lhs branch September 27, 2020 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants