[Merged by Bors] - chore(data/fintype/card): review API #4287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
urkud
changed the title
urkud
changed the title
urkud
changed the title
urkud
commented
Sep 27, 2020
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Sep 28, 2020
API changes: * `finset.filter_mem_eq_inter` now takes `[Π i, decidable (i ∈ t)]`; this way it works better with `classical`; * add `finset.mem_compl` and `finset.coe_compl`; * [DRY] drop `finset.prod_range_eq_prod_fin` and `finset.sum_range_eq_sum_fin`: use `fin.prod_univ_eq_prod_range` and `fin.sum_univ_eq_sum_range` instead; * rename `finset.prod_equiv` to `equiv.prod_comp` to enable dot notation; * add `fintype.prod_dite`: a specialized version of `finset.prod_dite`. Also golf a proof in `analysis/normed_space/multilinear`
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
API changes:
finset.filter_mem_eq_internow takes[Π i, decidable (i ∈ t)]; this way it works betterwith
classical;finset.mem_complandfinset.coe_compl;finset.prod_range_eq_prod_finandfinset.sum_range_eq_sum_fin:use
fin.prod_univ_eq_prod_rangeandfin.sum_univ_eq_sum_rangeinstead;finset.prod_equivtoequiv.prod_compto enable dot notation;fintype.prod_dite: a specialized version offinset.prod_dite.Also golf a proof in
analysis/normed_space/multilinear