Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(data/multiset): ordered sum lemmas #4305

Closed
wants to merge 3 commits into from

Conversation

b-mehta
Copy link
Collaborator

@b-mehta b-mehta commented Sep 28, 2020

Add some lemmas about products in ordered monoids and sums in ordered add monoids, and a multiset count filter lemma (and a rename of a count filter lemma)

@b-mehta b-mehta added the awaiting-review The author would like community review of the PR label Sep 28, 2020
Co-authored-by: Aaron Anderson <65780815+awainverse@users.noreply.github.com>
@Vierkantor Vierkantor self-requested a review September 30, 2020 08:55
src/data/list/basic.lean Outdated Show resolved Hide resolved
src/data/list/basic.lean Outdated Show resolved Hide resolved
src/data/list/basic.lean Outdated Show resolved Hide resolved
src/data/multiset/basic.lean Outdated Show resolved Hide resolved
@Vierkantor Vierkantor added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Sep 30, 2020
@b-mehta b-mehta added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Oct 2, 2020
Copy link
Collaborator

@Vierkantor Vierkantor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

bors r+

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Oct 2, 2020
bors bot pushed a commit that referenced this pull request Oct 2, 2020
Add some lemmas about products in ordered monoids and sums in ordered add monoids, and a multiset count filter lemma (and a rename of a count filter lemma)
@bors
Copy link

bors bot commented Oct 2, 2020

Build failed:

@bryangingechen
Copy link
Collaborator

There was a github actions issue. Let's try again.
bors r+

bors bot pushed a commit that referenced this pull request Oct 2, 2020
Add some lemmas about products in ordered monoids and sums in ordered add monoids, and a multiset count filter lemma (and a rename of a count filter lemma)
@bors
Copy link

bors bot commented Oct 2, 2020

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(data/multiset): ordered sum lemmas [Merged by Bors] - feat(data/multiset): ordered sum lemmas Oct 2, 2020
@bors bors bot closed this Oct 2, 2020
@bors bors bot deleted the multiset-sum-zero branch October 2, 2020 22:58
adomani pushed a commit that referenced this pull request Oct 7, 2020
Add some lemmas about products in ordered monoids and sums in ordered add monoids, and a multiset count filter lemma (and a rename of a count filter lemma)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants