Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(attribute/to_additive): apply to_additive recursively #431

Closed

Conversation

cipher1024
Copy link
Collaborator

TO CONTRIBUTORS:

Make sure you have:

  • reviewed and applied the coding style: coding, naming
  • for tactics:
  • make sure definitions and lemmas are put in the right files
  • make sure definitions and lemmas are not redundant

For reviewers: code review check list

@cipher1024
Copy link
Collaborator Author

@digama0, @johoelzl: any thoughts?

@johoelzl
Copy link
Collaborator

johoelzl commented Nov 5, 2018

This looks great!

@robertylewis
Copy link
Member

There are conflicts here now, but I think this should be mergeable when those are fixed.

@cipher1024
Copy link
Collaborator Author

Actually, I put this PR on hold as I looked at other projects. There's something broken about the way I put this into application. I'm going to try to make it work today.

@robertylewis
Copy link
Member

@cipher1024 This is from October and has various conflicts. Can we close and reopen if/when you come back to it?

@cipher1024
Copy link
Collaborator Author

Ok, sure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WIP Work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants