Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(algebra/ordered*): more simp lemmas #4359

Closed
wants to merge 14 commits into from

Conversation

urkud
Copy link
Member

@urkud urkud commented Oct 2, 2020

Simplify expressions like 0 < a * b, 0 < a / b, a / b < 1 etc. to FOL formulas of inequalities on a, b.


Zulip thread

@urkud urkud added the WIP Work in progress label Oct 2, 2020
@urkud urkud added awaiting-review The author would like community review of the PR and removed WIP Work in progress labels Oct 2, 2020
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I expected that there would be much more breakage...

LGTM

Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Oct 3, 2020
bors bot pushed a commit that referenced this pull request Oct 3, 2020
Simplify expressions like `0 < a * b`, `0 < a / b`, `a / b < 1` etc. to FOL formulas of inequalities on `a`, `b`.
@bors
Copy link

bors bot commented Oct 3, 2020

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(algebra/ordered*): more simp lemmas [Merged by Bors] - feat(algebra/ordered*): more simp lemmas Oct 3, 2020
@bors bors bot closed this Oct 3, 2020
@bors bors bot deleted the mul-pos-iff branch October 3, 2020 23:35
adomani pushed a commit that referenced this pull request Oct 7, 2020
Simplify expressions like `0 < a * b`, `0 < a / b`, `a / b < 1` etc. to FOL formulas of inequalities on `a`, `b`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants