Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(archive/imo): revive @kbuzzard's imo2019_q1 #4377

Closed
wants to merge 5 commits into from
Closed

[Merged by Bors] - feat(archive/imo): revive @kbuzzard's imo2019_q1 #4377

wants to merge 5 commits into from

Conversation

dselsam
Copy link
Collaborator

@dselsam dselsam commented Oct 3, 2020 •
edited by github-actions bot

@urkud
Copy link
Member

urkud commented Oct 3, 2020

I'll try to golf the proof.

@dselsam
Copy link
Collaborator Author

dselsam commented Oct 3, 2020

What does "golf" mean in this context?

@jcommelin
Copy link
Member

ascii length

@jcommelin jcommelin added the awaiting-review The author would like community review of the PR label Oct 3, 2020
@urkud
Copy link
Member

urkud commented Oct 3, 2020

I took the opportunity to add some @[simp] attributes to some lemmas about subtraction. Let's see if the build fails.

@urkud
Copy link
Member

urkud commented Oct 3, 2020

It seems that the CI doesn't run on this branch. I'm running the build locally.

@urkud
Copy link
Member

urkud commented Oct 3, 2020

@dselsam I've sent you an invitation to access non-master branches of this repo. If you make a PR from a branch in this repo, then CI will build oleans and upload them to Azure so that leanproject get-cache can download them.

@urkud
Copy link
Member

urkud commented Oct 3, 2020

I've also pushed to https://github.com/leanprover-community/mathlib/tree/imo2019_q1 to make CI build it.

@dselsam
Copy link
Collaborator Author

dselsam commented Oct 3, 2020

I took the opportunity to add some @[simp] attributes to some lemmas about subtraction. Let's see if the build fails.

new proof is much nicer!

@jcommelin
Copy link
Member

bors try

bors bot added a commit that referenced this pull request Oct 3, 2020
@bors
Try #4377:
4078cdf
@bors
Copy link

bors bot commented Oct 3, 2020

try

Build failed:

@urkud urkud mentioned this pull request Oct 3, 2020
Closed
@urkud
Copy link
Member

urkud commented Oct 3, 2020

I moved lemmas to a separate PR.

@bryangingechen bryangingechen added the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Oct 3, 2020
@github-actions github-actions bot added the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Oct 5, 2020
@bryangingechen bryangingechen removed the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Oct 6, 2020
@jcommelin jcommelin added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Oct 6, 2020
@bryangingechen bryangingechen mentioned this pull request Oct 6, 2020
Closed
@github-actions github-actions bot removed the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Oct 8, 2020
@urkud
Copy link
Member

urkud commented Oct 8, 2020

bors try

bors bot added a commit that referenced this pull request Oct 8, 2020
@bors
Try #4377:
d0ad229
@urkud urkud added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Oct 8, 2020
@bors
Copy link

bors bot commented Oct 8, 2020

try

Build succeeded:

@bryangingechen
Copy link
Collaborator

Thanks!
bors r+

@jcommelin jcommelin added the imo Formalisation of an IMO problem label Oct 8, 2020
bors bot pushed a commit that referenced this pull request Oct 8, 2020
@dselsam @urkud
feat(archive/imo): revive @kbuzzard's imo2019_q1 (#4377)
fe9d210 
Co-authored-by: Kevin Buzzard <k.buzzard@imperial.ac.uk>
Co-authored-by: Yury Kudryashov <urkud@urkud.name>



Co-authored-by: Yury G. Kudryashov <urkud@urkud.name>
@bors
Copy link

bors bot commented Oct 8, 2020

This PR was included in a batch that was canceled, it will be automatically retried

@bryangingechen bryangingechen mentioned this pull request Oct 8, 2020
Closed
bors bot pushed a commit that referenced this pull request Oct 8, 2020
@dselsam @urkud
feat(archive/imo): revive @kbuzzard's imo2019_q1 (#4377)
7b42c71 
Co-authored-by: Kevin Buzzard <k.buzzard@imperial.ac.uk>
Co-authored-by: Yury Kudryashov <urkud@urkud.name>



Co-authored-by: Yury G. Kudryashov <urkud@urkud.name>
@bors
Copy link

bors bot commented Oct 8, 2020

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(archive/imo): revive @kbuzzard's imo2019_q1 [Merged by Bors] - feat(archive/imo): revive @kbuzzard's imo2019_q1 Oct 8, 2020
@bors bors bot closed this Oct 8, 2020
@YaelDillies YaelDillies removed the awaiting-review The author would like community review of the PR label Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
imo Formalisation of an IMO problem
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dselsam @urkud @jcommelin @bryangingechen @YaelDillies