Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - chore(data/mv_polynomial): rename pderivative to pderiv #4381

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - chore(data/mv_polynomial): rename pderivative to pderiv #4381

wants to merge 1 commit into from

Conversation

urkud
Copy link
Member

@urkud urkud commented Oct 3, 2020

This name matches fderiv and deriv we have in analysis/.

@urkud
chore(data/mv_polynomial): rename pderivative to pderiv
f25e8c3 
This name matches `fderiv` and `deriv` we have in `analysis/`.
@urkud urkud added awaiting-review The author would like community review of the PR easy < 20s of review time. See the lifecycle page for guidelines. labels Oct 3, 2020
jcommelin
jcommelin approved these changes Oct 4, 2020
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

(What about polynomial.derivative?)

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Oct 4, 2020
bors bot pushed a commit that referenced this pull request Oct 4, 2020
@urkud
chore(data/mv_polynomial): rename pderivative to pderiv (#4381)
c3d0835 
This name matches `fderiv` and `deriv` we have in `analysis/`.
@bors
Copy link

bors bot commented Oct 4, 2020

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title chore(data/mv_polynomial): rename pderivative to pderiv [Merged by Bors] - chore(data/mv_polynomial): rename pderivative to pderiv Oct 4, 2020
@bors bors bot closed this Oct 4, 2020
@bors bors bot deleted the pderiv-rename branch October 4, 2020 07:53
adomani pushed a commit that referenced this pull request Oct 7, 2020
@urkud @adomani
chore(data/mv_polynomial): rename pderivative to pderiv (#4381)
b3e8cdf 
This name matches `fderiv` and `deriv` we have in `analysis/`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@urkud @jcommelin