Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(order/category/omega-complete): omega-complete partial orders form a complete category #4397

Closed
wants to merge 16 commits into from
Closed

[Merged by Bors] - feat(order/category/omega-complete): omega-complete partial orders form a complete category #4397

wants to merge 16 commits into from

Conversation

b-mehta
Copy link
Collaborator

@b-mehta b-mehta commented Oct 4, 2020

as discussed in #4348.

@b-mehta b-mehta added the awaiting-review The author would like community review of the PR label Oct 4, 2020
@semorrison semorrison added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Oct 5, 2020
@b-mehta b-mehta added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Oct 5, 2020
@github-actions github-actions bot added the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Oct 6, 2020
@github-actions github-actions bot removed the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Oct 6, 2020
bryangingechen
bryangingechen reviewed Oct 6, 2020
View reviewed changes
Copy link
Collaborator

@bryangingechen bryangingechen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm guessing you didn't mean to remove the simps in the merge.

src/category_theory/limits/shapes/products.lean Show resolved Hide resolved
src/category_theory/limits/shapes/products.lean Show resolved Hide resolved
@b-mehta @bryangingechen
Apply suggestions from code review
ec87eab 
Co-authored-by: Bryan Gin-ge Chen <bryangingechen@gmail.com>
@cipher1024
Copy link
Collaborator

this looks good to me. From this point @b-mehta, how much is missing to have a CCC instance?

@b-mehta
Copy link
Collaborator Author

b-mehta commented Oct 12, 2020

From here I think the things you did in the original PR would work fine, I only intended this as a more general way of doing the binary product and terminal stuff you had!

@cipher1024
Copy link
Collaborator

Super! Thank you so much! If Scott is happy with this, I am too!

@semorrison
Copy link
Collaborator

Sorry about the delay!

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Oct 15, 2020
bors bot pushed a commit that referenced this pull request Oct 15, 2020
@b-mehta @semorrison
feat(order/category/omega-complete): omega-complete partial orders fo…
7fc29ef 
…rm a complete category (#4397)

as discussed in #4348.

Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
@bors
Copy link

bors bot commented Oct 15, 2020

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request Oct 15, 2020
@b-mehta @semorrison
feat(order/category/omega-complete): omega-complete partial orders fo…
81a1a75 
…rm a complete category (#4397)

as discussed in #4348.

Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
@bors
Copy link

bors bot commented Oct 15, 2020

Build failed:

@bryangingechen
Copy link
Collaborator

bors r+

bors bot pushed a commit that referenced this pull request Oct 16, 2020
@b-mehta @semorrison @bryangingechen
feat(order/category/omega-complete): omega-complete partial orders fo…
b0b61e6 
…rm a complete category (#4397)

as discussed in #4348.

Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
Co-authored-by: Bryan Gin-ge Chen <bryangingechen@gmail.com>
@bors
Copy link

bors bot commented Oct 16, 2020

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(order/category/omega-complete): omega-complete partial orders form a complete category [Merged by Bors] - feat(order/category/omega-complete): omega-complete partial orders form a complete category Oct 16, 2020
@bors bors bot closed this Oct 16, 2020
@bors bors bot deleted the cpo-complete branch October 16, 2020 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bryangingechen bryangingechen bryangingechen left review comments

@cipher1024 cipher1024 Awaiting requested review from cipher1024

@semorrison semorrison Awaiting requested review from semorrison

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@b-mehta @cipher1024 @semorrison @bryangingechen