Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - chore(*/multilinear): generalize comp_linear_map to a family of linear maps #4408

Closed
wants to merge 5 commits into from
Closed

[Merged by Bors] - chore(*/multilinear): generalize comp_linear_map to a family of linear maps #4408

wants to merge 5 commits into from

Conversation

urkud
Copy link
Member

@urkud urkud commented Oct 5, 2020

Together with #4316 this will give us multilinear maps corresponding to monomials.

@urkud urkud added the awaiting-review The author would like community review of the PR label Oct 5, 2020
Vierkantor
Vierkantor approved these changes Oct 5, 2020
View reviewed changes
Copy link
Collaborator

@Vierkantor Vierkantor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of style suggestions, looks good to me otherwise!

bors d+

src/topology/algebra/multilinear.lean Outdated Show resolved Hide resolved
src/linear_algebra/multilinear.lean Outdated Show resolved Hide resolved
@bors
Copy link

bors bot commented Oct 5, 2020

✌️ urkud can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@Vierkantor Vierkantor added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Oct 5, 2020
@urkud @Vierkantor
Apply suggestions from code review
2b70fd9 
Co-authored-by: Vierkantor <Vierkantor@users.noreply.github.com>
Vierkantor
Vierkantor approved these changes Oct 5, 2020
View reviewed changes
Copy link
Collaborator

@Vierkantor Vierkantor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

bors r+

@github-actions github-actions bot added the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label Oct 5, 2020
bors bot pushed a commit that referenced this pull request Oct 5, 2020
@urkud
chore(*/multilinear): generalize comp_linear_map to a family of lin…
5f9f955 
…ear maps (#4408)

Together with #4316 this will give us multilinear maps corresponding to monomials.
@bors
Copy link

bors bot commented Oct 5, 2020

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request Oct 5, 2020
@urkud
chore(*/multilinear): generalize comp_linear_map to a family of lin…
e89d0ed 
…ear maps (#4408)

Together with #4316 this will give us multilinear maps corresponding to monomials.
@bors
Copy link

bors bot commented Oct 5, 2020

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title chore(*/multilinear): generalize comp_linear_map to a family of linear maps [Merged by Bors] - chore(*/multilinear): generalize comp_linear_map to a family of linear maps Oct 5, 2020
@bors bors bot closed this Oct 5, 2020
@bors bors bot deleted the multilinear-comp-linear branch October 5, 2020 19:44
@urkud urkud restored the multilinear-comp-linear branch October 5, 2020 20:33
@urkud urkud deleted the multilinear-comp-linear branch October 5, 2020 20:33
adomani pushed a commit that referenced this pull request Oct 7, 2020
@urkud @adomani
chore(*/multilinear): generalize comp_linear_map to a family of lin…
cdf3bc5 
…ear maps (#4408)

Together with #4316 this will give us multilinear maps corresponding to monomials.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-wieser eric-wieser eric-wieser approved these changes

@hrmacbeth hrmacbeth hrmacbeth left review comments

@Vierkantor Vierkantor Vierkantor approved these changes

Assignees
No one assigned
Labels
delegated The PR author may merge after reviewing final suggestions. ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@urkud @eric-wieser @Vierkantor @hrmacbeth