Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore(linear_algebra/basis): split off linear_independent.lean #4440

Closed
wants to merge 1 commit into from

Conversation

Vierkantor
Copy link
Collaborator

The file basis.lean was getting rather long (1500 lines), so I decided to split it into two not as long files at a natural point: everything using linear_independent but not basis can go into a new file linear_independent.lean. As a result, we can import basis.lean a bit later in the ring_theory hierarchy.


The file `basis.lean` was getting rather long (1500 lines), so I decided to
split it into two not as long files. As a result, we can import it a bit later
in the `ring_theory` hierarchy.
@Vierkantor Vierkantor added the awaiting-review The author would like community review of the PR label Oct 5, 2020
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Oct 5, 2020
bors bot pushed a commit that referenced this pull request Oct 5, 2020
The file `basis.lean` was getting rather long (1500 lines), so I decided to split it into two not as long files at a natural point: everything using `linear_independent` but not `basis` can go into a new file `linear_independent.lean`. As a result, we can import `basis.lean` a bit later in the `ring_theory` hierarchy.
@bors
Copy link

bors bot commented Oct 5, 2020

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title chore(linear_algebra/basis): split off linear_independent.lean [Merged by Bors] - chore(linear_algebra/basis): split off linear_independent.lean Oct 5, 2020
@bors bors bot closed this Oct 5, 2020
@bors bors bot deleted the split_lin_ind branch October 5, 2020 22:01
adomani pushed a commit that referenced this pull request Oct 7, 2020
The file `basis.lean` was getting rather long (1500 lines), so I decided to split it into two not as long files at a natural point: everything using `linear_independent` but not `basis` can go into a new file `linear_independent.lean`. As a result, we can import `basis.lean` a bit later in the `ring_theory` hierarchy.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants