Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - chore(category_theory/*): doc-strings #4453

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - chore(category_theory/*): doc-strings #4453

wants to merge 2 commits into from

Conversation

semorrison
Copy link
Collaborator

@semorrison semorrison added awaiting-review The author would like community review of the PR lintfix This PR only fixes linting errors labels Oct 5, 2020
bryangingechen
bryangingechen reviewed Oct 6, 2020
View reviewed changes
Copy link
Collaborator

@bryangingechen bryangingechen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM.
bors d+

src/category_theory/endomorphism.lean Outdated Show resolved Hide resolved
src/category_theory/groupoid.lean Outdated Show resolved Hide resolved
@bors
Copy link

bors bot commented Oct 6, 2020

✌️ semorrison can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@bryangingechen bryangingechen added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Oct 6, 2020
@semorrison @bryangingechen
Apply suggestions from code review
4d7fa45 
Co-authored-by: Bryan Gin-ge Chen <bryangingechen@gmail.com>
@semorrison
Copy link
Collaborator Author

bors merge

@github-actions github-actions bot added the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label Oct 6, 2020
bors bot pushed a commit that referenced this pull request Oct 6, 2020
@semorrison
chore(category_theory/*): doc-strings (#4453)
fc4bc6c 
Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
@bors
Copy link

bors bot commented Oct 6, 2020

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request Oct 6, 2020
@semorrison
chore(category_theory/*): doc-strings (#4453)
fee6e3e 
Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
@bors
Copy link

bors bot commented Oct 6, 2020

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request Oct 6, 2020
@semorrison
chore(category_theory/*): doc-strings (#4453)
58a54d3 
Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
@bors
Copy link

bors bot commented Oct 6, 2020

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title chore(category_theory/*): doc-strings [Merged by Bors] - chore(category_theory/*): doc-strings Oct 6, 2020
@bors bors bot closed this Oct 6, 2020
@bors bors bot deleted the category_lints branch October 6, 2020 12:41
adomani pushed a commit that referenced this pull request Oct 7, 2020
@semorrison @adomani
chore(category_theory/*): doc-strings (#4453)
8504a90 
Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
@bryangingechen bryangingechen mentioned this pull request Oct 8, 2020
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bryangingechen bryangingechen bryangingechen left review comments

Assignees
No one assigned
Labels
delegated The PR author may merge after reviewing final suggestions. lintfix This PR only fixes linting errors ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@semorrison @bryangingechen