Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(ring_theory/witt_vector/structure_polynomial): witt_structure_rat{_prop} #4464

Closed
wants to merge 4 commits into from

Conversation

jcommelin
Copy link
Member

@jcommelin jcommelin commented Oct 6, 2020

This is the first PR in a series on a fundamental theorem for Witt polynomials.

Co-Authored-By: Rob Y. Lewis rob.y.lewis@gmail.com


Follow-up PRs: #4465 #4466 #4467 #4332
Draft PR for the big picture: #4331

…t{_prop}

This is the first PR in a series on a fundamental theorem for Witt polynomials.
Co-authored-by: Kenny Lau <kc_kennylau@yahoo.com.hk>
Copy link
Collaborator

@Vierkantor Vierkantor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy with merging this as-is, with a few cosmetic remarks.

src/ring_theory/witt_vector/structure_polynomial.lean Outdated Show resolved Hide resolved
src/ring_theory/witt_vector/structure_polynomial.lean Outdated Show resolved Hide resolved
src/ring_theory/witt_vector/structure_polynomial.lean Outdated Show resolved Hide resolved
src/ring_theory/witt_vector/structure_polynomial.lean Outdated Show resolved Hide resolved
Co-authored-by: Vierkantor <Vierkantor@users.noreply.github.com>
@Vierkantor
Copy link
Collaborator

Looks good to me. @kckennylau, any suggestions?

bors delegate=@kckennylau

@bors
Copy link

bors bot commented Oct 6, 2020

✌️ kckennylau can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@kckennylau
Copy link
Collaborator

bors r+

bors bot pushed a commit that referenced this pull request Oct 6, 2020
…t{_prop} (#4464)

This is the first PR in a series on a fundamental theorem for Witt polynomials.


Co-Authored-By: Rob Y. Lewis <rob.y.lewis@gmail.com>
@bors
Copy link

bors bot commented Oct 6, 2020

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(ring_theory/witt_vector/structure_polynomial): witt_structure_rat{_prop} [Merged by Bors] - feat(ring_theory/witt_vector/structure_polynomial): witt_structure_rat{_prop} Oct 6, 2020
@bors bors bot closed this Oct 6, 2020
@bors bors bot deleted the witt-struc5 branch October 6, 2020 22:45
@jcommelin jcommelin restored the witt-struc5 branch October 7, 2020 04:43
jcommelin added a commit that referenced this pull request Oct 7, 2020
…t{_prop} (#4464)

This is the first PR in a series on a fundamental theorem for Witt polynomials.


Co-Authored-By: Rob Y. Lewis <rob.y.lewis@gmail.com>
adomani pushed a commit that referenced this pull request Oct 7, 2020
…t{_prop} (#4464)

This is the first PR in a series on a fundamental theorem for Witt polynomials.


Co-Authored-By: Rob Y. Lewis <rob.y.lewis@gmail.com>
@robertylewis robertylewis deleted the witt-struc5 branch December 27, 2020 03:46
@YaelDillies YaelDillies removed the awaiting-review The author would like community review of the PR label Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants