Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - lint(order/order_iso_nat): docstrings #4488

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - lint(order/order_iso_nat): docstrings #4488

wants to merge 1 commit into from

Conversation

awainverse
Copy link
Collaborator

Adds docstrings to rel_embedding.nat_lt and rel_embedding.nat_gt

@awainverse awainverse added easy < 20s of review time. See the lifecycle page for guidelines. awaiting-review The author would like community review of the PR lintfix This PR only fixes linting errors labels Oct 6, 2020
bryangingechen
bryangingechen approved these changes Oct 6, 2020
View reviewed changes
Copy link
Collaborator

@bryangingechen bryangingechen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
bors r+

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Oct 6, 2020
bors bot pushed a commit that referenced this pull request Oct 7, 2020
@awainverse
lint(order/order_iso_nat): docstrings (#4488)
afffab1 
Adds docstrings to `rel_embedding.nat_lt` and `rel_embedding.nat_gt`
@bors
Copy link

bors bot commented Oct 7, 2020

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title lint(order/order_iso_nat): docstrings [Merged by Bors] - lint(order/order_iso_nat): docstrings Oct 7, 2020
@bors bors bot closed this Oct 7, 2020
@bors bors bot deleted the lint_order_iso_nat branch October 7, 2020 03:23
jcommelin pushed a commit that referenced this pull request Oct 7, 2020
@awainverse @jcommelin
lint(order/order_iso_nat): docstrings (#4488)
6d3d425 
Adds docstrings to `rel_embedding.nat_lt` and `rel_embedding.nat_gt`
adomani pushed a commit that referenced this pull request Oct 7, 2020
@awainverse @adomani
lint(order/order_iso_nat): docstrings (#4488)
7f9fdbe 
Adds docstrings to `rel_embedding.nat_lt` and `rel_embedding.nat_gt`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bryangingechen bryangingechen bryangingechen approved these changes

Assignees
No one assigned
Labels
easy < 20s of review time. See the lifecycle page for guidelines. lintfix This PR only fixes linting errors ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@awainverse @bryangingechen