Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - lint(group_theory/*): docstrings and an inhabited instance #4493

Closed
wants to merge 3 commits into from

Conversation

awainverse
Copy link
Collaborator

An inhabited instance for presented_group
Docstrings in group_theory/abelianization and group_theory/congruence.


@awainverse awainverse added awaiting-review The author would like community review of the PR easy < 20s of review time. See the lifecycle page for guidelines. lintfix This PR only fixes linting errors labels Oct 7, 2020
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors d+

src/group_theory/congruence.lean Outdated Show resolved Hide resolved
src/group_theory/congruence.lean Outdated Show resolved Hide resolved
@bors
Copy link

bors bot commented Oct 7, 2020

✌️ awainverse can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

Co-authored-by: Johan Commelin <johan@commelin.net>
@awainverse
Copy link
Collaborator Author

bors r+

bors bot pushed a commit that referenced this pull request Oct 7, 2020
An inhabited instance for `presented_group`
Docstrings in `group_theory/abelianization` and `group_theory/congruence`.



Co-authored-by: Aaron Anderson <65780815+awainverse@users.noreply.github.com>
@bors
Copy link

bors bot commented Oct 7, 2020

Canceled.

@bryangingechen
Copy link
Collaborator

bors r+

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Oct 7, 2020
bors bot pushed a commit that referenced this pull request Oct 7, 2020
An inhabited instance for `presented_group`
Docstrings in `group_theory/abelianization` and `group_theory/congruence`.



Co-authored-by: Aaron Anderson <65780815+awainverse@users.noreply.github.com>
Co-authored-by: Bryan Gin-ge Chen <bryangingechen@gmail.com>
@bors
Copy link

bors bot commented Oct 7, 2020

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title lint(group_theory/*): docstrings and an inhabited instance [Merged by Bors] - lint(group_theory/*): docstrings and an inhabited instance Oct 7, 2020
@bors bors bot closed this Oct 7, 2020
@bors bors bot deleted the lint_group branch October 7, 2020 07:56
jcommelin pushed a commit that referenced this pull request Oct 7, 2020
An inhabited instance for `presented_group`
Docstrings in `group_theory/abelianization` and `group_theory/congruence`.



Co-authored-by: Aaron Anderson <65780815+awainverse@users.noreply.github.com>
Co-authored-by: Bryan Gin-ge Chen <bryangingechen@gmail.com>
adomani pushed a commit that referenced this pull request Oct 7, 2020
An inhabited instance for `presented_group`
Docstrings in `group_theory/abelianization` and `group_theory/congruence`.



Co-authored-by: Aaron Anderson <65780815+awainverse@users.noreply.github.com>
Co-authored-by: Bryan Gin-ge Chen <bryangingechen@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy < 20s of review time. See the lifecycle page for guidelines. lintfix This PR only fixes linting errors ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants