Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(topology/basic): Lim_spec etc. cleanup #4545

Closed
wants to merge 8 commits into from
Closed

[Merged by Bors] - feat(topology/basic): Lim_spec etc. cleanup #4545

wants to merge 8 commits into from

Conversation

adamtopaz
Copy link
Collaborator

@adamtopaz adamtopaz commented Oct 8, 2020 •
edited by urkud

@adamtopaz adamtopaz added the awaiting-review The author would like community review of the PR label Oct 8, 2020
urkud
urkud reviewed Oct 9, 2020
View reviewed changes
Copy link
Member

@urkud urkud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor style comments. h1 ▸ h2 is an alternative syntax for by { rw ← h1, exact h2 } (though the latter works in more cases).

src/topology/separation.lean Outdated Show resolved Hide resolved
src/topology/separation.lean Outdated Show resolved Hide resolved
src/topology/separation.lean Outdated Show resolved Hide resolved
src/topology/subset_properties.lean Outdated Show resolved Hide resolved
urkud
urkud reviewed Oct 9, 2020
View reviewed changes
Copy link
Member

@urkud urkud left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(deleted)

@urkud
Copy link
Member

urkud commented Oct 9, 2020

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Oct 9, 2020
bors bot pushed a commit that referenced this pull request Oct 9, 2020
@adamtopaz @urkud
feat(topology/basic): Lim_spec etc. cleanup (#4545)
b167809 
Fixes #4543
See [Zulip discussion](https://leanprover.zulipchat.com/#narrow/stream/217875-Is-there.20code.20for.20X.3F/topic/More.20point.20set.20topology.20questions/near/212757136)



Co-authored-by: Yury G. Kudryashov <urkud@urkud.name>
@bors
Copy link

bors bot commented Oct 9, 2020

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(topology/basic): Lim_spec etc. cleanup [Merged by Bors] - feat(topology/basic): Lim_spec etc. cleanup Oct 9, 2020
@bors bors bot closed this Oct 9, 2020
@bors bors bot deleted the lim_spec_cleanup branch October 9, 2020 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@urkud urkud urkud left review comments

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cleanup lim_spec etc
2 participants
@adamtopaz @urkud