Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - refactor(data/int/gcd,ring_theory/int/basic): collect integer divisibility results from various files #4572

Closed
wants to merge 7 commits into from
Closed

[Merged by Bors] - refactor(data/int/gcd,ring_theory/int/basic): collect integer divisibility results from various files #4572

wants to merge 7 commits into from

Conversation

paulvanwamelen
Copy link
Collaborator

Applying comments from PR #4384. In particular:

  1. Move the gcd and lcm results from gcd_monoid to data/int/gcd.lean with new proofs (for a few lcm results) that do not need ring theory.
  2. Try to collect applications of ring theory to ℕ and ℤ into a new file ring_theory/int/basic.lean.

@paulvanwamelen paulvanwamelen mentioned this pull request Oct 11, 2020
Closed
@urkud urkud changed the title refactor(reing_theory/int/gcd) collect integer divisibility results from various files refactor(ring_theory/int/gcd) collect integer divisibility results from various files Oct 11, 2020
@urkud
Copy link
Member

urkud commented Oct 11, 2020

Is it ready for review? If yes, please add awaiting-review label.

@bryangingechen bryangingechen changed the title refactor(ring_theory/int/gcd) collect integer divisibility results from various files refactor(ring_theory/int/gcd): collect integer divisibility results from various files Oct 11, 2020
@bryangingechen bryangingechen changed the title refactor(ring_theory/int/gcd): collect integer divisibility results from various files refactor(data/int/gcd,ring_theory/int/basic): collect integer divisibility results from various files Oct 11, 2020
@paulvanwamelen paulvanwamelen added the awaiting-review The author would like community review of the PR label Oct 11, 2020
awainverse
awainverse approved these changes Oct 12, 2020
View reviewed changes
Copy link
Collaborator

@awainverse awainverse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks great to me.
I'm pretty sure that ring_theory/int/basic shouldn't be too much to import in any of these cases...

jcommelin
jcommelin reviewed Oct 13, 2020
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/ring_theory/int/basic.lean Outdated Show resolved Hide resolved
src/data/int/gcd.lean Outdated Show resolved Hide resolved
@jcommelin jcommelin added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Oct 13, 2020
paulvanwamelen and others added 2 commits October 13, 2020 10:27
@paulvanwamelen @jcommelin
Update src/ring_theory/int/basic.lean
0394138 
Co-authored-by: Johan Commelin <johan@commelin.net>
@paulvanwamelen @jcommelin
Update src/data/int/gcd.lean
ad9fc27 
Co-authored-by: Johan Commelin <johan@commelin.net>
@paulvanwamelen paulvanwamelen added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Oct 14, 2020
jcommelin
jcommelin approved these changes Oct 14, 2020
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Oct 14, 2020
bors bot pushed a commit that referenced this pull request Oct 14, 2020
@paulvanwamelen
refactor(data/int/gcd,ring_theory/int/basic): collect integer divisib…
8511729 
…ility results from various files (#4572)

Applying comments from PR #4384. In particular:
1) Move the gcd and lcm results from gcd_monoid to `data/int/gcd.lean` with new proofs (for a few lcm results) that do not need ring theory.
2) Try to collect applications of ring theory to ℕ and ℤ into a new file `ring_theory/int/basic.lean`. 

Co-authored-by: paulvanwamelen <30371019+paulvanwamelen@users.noreply.github.com>
@bors
Copy link

bors bot commented Oct 14, 2020

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title refactor(data/int/gcd,ring_theory/int/basic): collect integer divisibility results from various files [Merged by Bors] - refactor(data/int/gcd,ring_theory/int/basic): collect integer divisibility results from various files Oct 14, 2020
@bors bors bot closed this Oct 14, 2020
@bors bors bot deleted the reorg_int_gcd2 branch October 14, 2020 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin approved these changes

@awainverse awainverse awainverse approved these changes

@semorrison semorrison Awaiting requested review from semorrison

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@paulvanwamelen @urkud @jcommelin @awainverse