[Merged by Bors] - chore(linear_algebra/dimension): more same-universe versions of is_basis.mk_eq_dim
#4591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM bors merge |
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Oct 13, 2020
…asis.mk_eq_dim` (#4591) While all the `lift` magic is good for general theory, it is not that convenient for the case when everything is in `Type`. * add `mk_eq_mk_of_basis'`: same-universe version of `mk_eq_mk_of_basis`; * generalize `is_basis.mk_eq_dim''` to any index type in the same universe as `V`, not necessarily `s : set V`; * reorder lemmas to optimize the total length of the proofs; * drop one `finite_dimensional` assumption in `findim_of_infinite_dimensional`.
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
is_basis.mk_eq_dimis_basis.mk_eq_dim
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While all the
liftmagic is good for general theory, it is not that convenient for the case when everything is inType.mk_eq_mk_of_basis': same-universe version ofmk_eq_mk_of_basis;is_basis.mk_eq_dim''to any index type in the same universe asV, not necessarilys : set V;finite_dimensionalassumption infindim_of_infinite_dimensional.