Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(data/set/intervals): more lemmas about unordered_interval #4607

Closed
wants to merge 5 commits into from
Closed

[Merged by Bors] - feat(data/set/intervals): more lemmas about unordered_interval #4607

wants to merge 5 commits into from

Conversation

urkud
Copy link
Member

@urkud urkud commented Oct 13, 2020

Add images/preimages of unordered intervals under common arithmetic operations.

@urkud urkud added awaiting-review The author would like community review of the PR easy < 20s of review time. See the lifecycle page for guidelines. labels Oct 13, 2020
@urkud
Copy link
Member Author

urkud commented Oct 13, 2020 •
edited

@PatrickMassot These lemmas originate from my convex-affine branch.

@ADedecker
Copy link
Member

Not a maintainer, but LGTM

jcommelin
jcommelin approved these changes Oct 14, 2020
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Oct 14, 2020
bors bot pushed a commit that referenced this pull request Oct 14, 2020
@urkud
feat(data/set/intervals): more lemmas about unordered_interval (#4607)
060e4a7 
Add images/preimages of unordered intervals under common arithmetic operations.
@bors
Copy link

bors bot commented Oct 14, 2020

This PR was included in a batch that successfully built, but then failed to merge into master (it was a non-fast-forward update). It will be automatically retried.

bors bot pushed a commit that referenced this pull request Oct 14, 2020
@urkud
feat(data/set/intervals): more lemmas about unordered_interval (#4607)
de46349 
Add images/preimages of unordered intervals under common arithmetic operations.
@bryangingechen bryangingechen mentioned this pull request Oct 14, 2020
Merged
@bors
Copy link

bors bot commented Oct 14, 2020

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(data/set/intervals): more lemmas about unordered_interval [Merged by Bors] - feat(data/set/intervals): more lemmas about unordered_interval Oct 14, 2020
@bors bors bot closed this Oct 14, 2020
@bors bors bot deleted the unordered-interval2 branch October 14, 2020 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@urkud @ADedecker @jcommelin