Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(archive/100-theorems-list/70_perfect_numbers): Perfect Number Theorem, Direction 2 #4621

Closed
wants to merge 5 commits into from

Conversation

awainverse
Copy link
Collaborator

Adds a few extra lemmas about divisors, proper_divisors and sums of proper divisors
Proves Euler's direction of the Perfect Number theorem, finishing Freek 70


@awainverse awainverse added the awaiting-review The author would like community review of the PR label Oct 15, 2020
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add the result to 100.yaml?

archive/100-theorems-list/70_perfect_numbers.lean Outdated Show resolved Hide resolved
src/number_theory/divisors.lean Show resolved Hide resolved
src/number_theory/divisors.lean Show resolved Hide resolved
@jcommelin jcommelin added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Oct 15, 2020
@awainverse awainverse added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Oct 15, 2020
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Oct 15, 2020
bors bot pushed a commit that referenced this pull request Oct 15, 2020
…eorem, Direction 2 (#4621)

Adds a few extra lemmas about `divisors`, `proper_divisors` and sums of proper divisors
Proves Euler's direction of the Perfect Number theorem, finishing Freek 70
@bors
Copy link

bors bot commented Oct 15, 2020

Canceled.

@bryangingechen
Copy link
Collaborator

bors r+
(And just in case something fails again.)
bors d+

@bors
Copy link

bors bot commented Oct 15, 2020

✌️ awainverse can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

bors bot pushed a commit that referenced this pull request Oct 15, 2020
…eorem, Direction 2 (#4621)

Adds a few extra lemmas about `divisors`, `proper_divisors` and sums of proper divisors
Proves Euler's direction of the Perfect Number theorem, finishing Freek 70
@bors
Copy link

bors bot commented Oct 15, 2020

Canceled.

@awainverse
Copy link
Collaborator Author

I'm pretty sure that it'll build now that I've set up a link to the archive instead of a decl. I'll wait to merge until CI is all happy.

Perhaps we could have a separate conversation about whether we want to move this stuff into src.

@@ -224,7 +224,8 @@
author : mathlib
70:
title : The Perfect Number Theorem
decl : nat.even_and_perfect_iff
links :
mathlib archive : https://github.com/leanprover-community/mathlib/blob/master/archive/100-theorems-list/70_perfect_numbers.lean
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bryangingechen what is the correct way of linking here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works now, and at least one other Freek problem has this form, so I'll tell bors to merge.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it makes sense to move this to src/.
As far as I know, there are not really any other applications of perfect numbers, so far. So leaving it in the archive seems fine for now.

@awainverse
Copy link
Collaborator Author

bors r+

bors bot pushed a commit that referenced this pull request Oct 15, 2020
…eorem, Direction 2 (#4621)

Adds a few extra lemmas about `divisors`, `proper_divisors` and sums of proper divisors
Proves Euler's direction of the Perfect Number theorem, finishing Freek 70
@bors
Copy link

bors bot commented Oct 15, 2020

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(archive/100-theorems-list/70_perfect_numbers): Perfect Number Theorem, Direction 2 [Merged by Bors] - feat(archive/100-theorems-list/70_perfect_numbers): Perfect Number Theorem, Direction 2 Oct 15, 2020
@bors bors bot closed this Oct 15, 2020
@bors bors bot deleted the perfect branch October 15, 2020 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants