Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - chore(set_theory/zfc): split long lines #4641

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - chore(set_theory/zfc): split long lines #4641

wants to merge 2 commits into from

Conversation

urkud
Copy link
Member

@urkud urkud commented Oct 16, 2020

Also add Set.subset_def and rewrite Set.mem_pair_sep in tactic mode

@urkud
chore(set_theory/zfc): split long lines
db5d34f 
Also add `Set.subset_def` and rewrite `Set.mem_pair_sep` in tactic mode
@urkud urkud added the awaiting-review The author would like community review of the PR label Oct 16, 2020
bryangingechen
bryangingechen approved these changes Oct 16, 2020
View reviewed changes
Copy link
Collaborator

@bryangingechen bryangingechen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
bors r+

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Oct 16, 2020
digama0
digama0 reviewed Oct 16, 2020
View reviewed changes
src/set_theory/zfc.lean Outdated Show resolved Hide resolved
src/set_theory/zfc.lean Outdated Show resolved Hide resolved
src/set_theory/zfc.lean Outdated Show resolved Hide resolved
@digama0
Copy link
Member

digama0 commented Oct 16, 2020

Pause bors for review comments:

bors r-

@bors
Copy link

bors bot commented Oct 16, 2020

Canceled.

urkud
urkud commented Oct 16, 2020
View reviewed changes
Copy link
Member Author

@urkud urkud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add GH suggestions following @digama0's comments

src/set_theory/zfc.lean Outdated Show resolved Hide resolved
src/set_theory/zfc.lean Outdated Show resolved Hide resolved
src/set_theory/zfc.lean Outdated Show resolved Hide resolved
@urkud urkud added awaiting-review The author would like community review of the PR and removed ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) labels Oct 16, 2020
@urkud
Copy link
Member Author

urkud commented Oct 16, 2020

@digama0 Done

@digama0
Copy link
Member

digama0 commented Oct 16, 2020

bors r+

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Oct 16, 2020
bors bot pushed a commit that referenced this pull request Oct 16, 2020
@urkud
chore(set_theory/zfc): split long lines (#4641)
f675a00 
Also add `Set.subset_def` and rewrite `Set.mem_pair_sep` in tactic mode
@bors
Copy link

bors bot commented Oct 16, 2020

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title chore(set_theory/zfc): split long lines [Merged by Bors] - chore(set_theory/zfc): split long lines Oct 16, 2020
@bors bors bot closed this Oct 16, 2020
@bors bors bot deleted the zfc-reflow branch October 16, 2020 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@digama0 digama0 digama0 left review comments

@bryangingechen bryangingechen bryangingechen approved these changes

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@urkud @digama0 @bryangingechen