Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(finsupp/basic): Add a variant of prod_map_domain_index for when f is injective #4645

Closed
wants to merge 2 commits into from

Conversation

eric-wieser
Copy link
Member

@eric-wieser eric-wieser commented Oct 16, 2020

This puts much weaker restrictions on h, making this easier to apply in some situations


@eric-wieser eric-wieser added awaiting-review The author would like community review of the PR easy < 20s of review time. See the lifecycle page for guidelines. labels Oct 16, 2020
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Oct 17, 2020
bors bot pushed a commit that referenced this pull request Oct 17, 2020
…n f is injective (#4645)

This puts much weaker restrictions on `h`, making this easier to apply in some situations
@bors
Copy link

bors bot commented Oct 17, 2020

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(finsupp/basic): Add a variant of prod_map_domain_index for when f is injective [Merged by Bors] - feat(finsupp/basic): Add a variant of prod_map_domain_index for when f is injective Oct 17, 2020
@bors bors bot closed this Oct 17, 2020
@bors bors bot deleted the eric-wieser/sum_emb_domain branch October 17, 2020 20:49
b-mehta pushed a commit that referenced this pull request Oct 20, 2020
…n f is injective (#4645)

This puts much weaker restrictions on `h`, making this easier to apply in some situations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants