[Merged by Bors] - feat(simps): improve error messages #4653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fpvandoorn
added
the
awaiting-review
This was referenced Oct 17, 2020
semorrison
reviewed
Oct 19, 2020
semorrison
reviewed
Oct 19, 2020
src/tactic/simps.lean
Outdated
Comment on lines
20
to
22
| * `@[_simps_str]` is automatically added to structures that have been used in `@[simps]` at least | ||
| once. They contain the data of the projections used for this structure by all following | ||
| invocations of `@[simps]`. |
There was a problem hiding this comment.
I'm not sure what the referent of They is in "They contain the data". Could you add a bit more here?
semorrison
reviewed
Oct 19, 2020
semorrison
reviewed
Oct 19, 2020
|
LGTM. I'll |
semorrison
added
awaiting-author
|
Thanks for this, this would have definitely saved me the confusion I had on Zulip! |
Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
fpvandoorn
added
awaiting-review
|
@semorrison ping |
|
bors merge |
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Oct 26, 2020
If a custom projection has a different type than the expected projection, then it will show a more specific error message. Also reflow most long lines Also add some tests
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a custom projection has a different type than the expected projection, then it will show a more specific error message.
Also reflow most long lines
Also add some tests
Not sure what to do with strings of
>100characters without newline in it.@eric-wieser