Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(algebra/gcd_monoid, polynomial/field_division): generalizing normalization_monoid on polynomials #4655

Closed
wants to merge 4 commits into from

Conversation

awainverse
Copy link
Collaborator

Defines a normalization_monoid instance on any comm_group_with_zero, including fields
Defines a normalization_monoid instance on polynomial R when R has a normalization_monoid instance


@awainverse awainverse added the awaiting-review The author would like community review of the PR label Oct 17, 2020
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/data/polynomial/field_division.lean Outdated Show resolved Hide resolved
@jcommelin
Copy link
Member

Thanks 🎉

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Oct 17, 2020
bors bot pushed a commit that referenced this pull request Oct 17, 2020
…rmalization_monoid` on polynomials (#4655)

Defines a `normalization_monoid` instance on any `comm_group_with_zero`, including fields
Defines a `normalization_monoid` instance on `polynomial R` when `R` has a `normalization_monoid` instance



Co-authored-by: Johan Commelin <johan@commelin.net>
@bors
Copy link

bors bot commented Oct 17, 2020

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(algebra/gcd_monoid, polynomial/field_division): generalizing normalization_monoid on polynomials [Merged by Bors] - feat(algebra/gcd_monoid, polynomial/field_division): generalizing normalization_monoid on polynomials Oct 17, 2020
@bors bors bot closed this Oct 17, 2020
@bors bors bot deleted the polynomial_normalization branch October 17, 2020 20:49
b-mehta pushed a commit that referenced this pull request Oct 20, 2020
…rmalization_monoid` on polynomials (#4655)

Defines a `normalization_monoid` instance on any `comm_group_with_zero`, including fields
Defines a `normalization_monoid` instance on `polynomial R` when `R` has a `normalization_monoid` instance



Co-authored-by: Johan Commelin <johan@commelin.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants