Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - chore(topology/algebra/ordered): drop section vars, golf 2 proofs #4706

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - chore(topology/algebra/ordered): drop section vars, golf 2 proofs #4706

wants to merge 1 commit into from

Conversation

urkud
Copy link
Member

@urkud urkud commented Oct 20, 2020

  • Explicitly specify explicit arguments instead of using section
    variables;
  • Add continuous_min and continuous_max;
  • Use them for tendsto.min and tendsto.max

@urkud
chore(topology/algebra/ordered): drop section vars, golf 2 proofs
6bb049d 
* Explicitly specify explicit arguments instead of using section
  variables;
* Add `continuous_min` and `continuous_max`;
* Use them for `tendsto.min` and `tendsto.max`
@urkud urkud added the awaiting-review The author would like community review of the PR label Oct 20, 2020
jcommelin
jcommelin approved these changes Oct 20, 2020
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Oct 20, 2020
bors bot pushed a commit that referenced this pull request Oct 20, 2020
@urkud
chore(topology/algebra/ordered): drop section vars, golf 2 proofs (#4706
21415c8 
)

* Explicitly specify explicit arguments instead of using section
  variables;
* Add `continuous_min` and `continuous_max`;
* Use them for `tendsto.min` and `tendsto.max`
@bors
Copy link

bors bot commented Oct 20, 2020

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title chore(topology/algebra/ordered): drop section vars, golf 2 proofs [Merged by Bors] - chore(topology/algebra/ordered): drop section vars, golf 2 proofs Oct 20, 2020
@bors bors bot closed this Oct 20, 2020
@bors bors bot deleted the continuous-min branch October 20, 2020 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@urkud @jcommelin