Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore(data/equiv/basic): Add a simp lemma perm.coe_mul #4723

Closed
wants to merge 2 commits into from

Conversation

eric-wieser
Copy link
Member

This mirrors equiv.coe_trans


@eric-wieser eric-wieser added awaiting-review The author would like community review of the PR easy < 20s of review time. See the lifecycle page for guidelines. labels Oct 21, 2020
@jcommelin
Copy link
Member

If you can make the linter happy (shouldn't be hard), feel free to merge 😄

bors d+

@bors
Copy link

bors bot commented Oct 22, 2020

✌️ eric-wieser can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@jcommelin jcommelin added awaiting-author A reviewer has asked the author a question or requested changes delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Oct 22, 2020
@eric-wieser
Copy link
Member Author

bors r+

bors bot pushed a commit that referenced this pull request Oct 22, 2020
@bryangingechen
Copy link
Collaborator

Well, it's too late now, but the PR title / commit should have been edited to remove "simp".

@eric-wieser
Copy link
Member Author

eric-wieser commented Oct 22, 2020

Why? The new lemma is still simp, an old lemma just stopped being simp

@bryangingechen
Copy link
Collaborator

Oh, I was looking at the wrong commit. I should have had my coffee first before commenting...

@bors
Copy link

bors bot commented Oct 22, 2020

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title chore(data/equiv/basic): Add a simp lemma perm.coe_mul [Merged by Bors] - chore(data/equiv/basic): Add a simp lemma perm.coe_mul Oct 22, 2020
@bors bors bot closed this Oct 22, 2020
@bors bors bot deleted the eric-wieser/perm.coe_mul branch October 22, 2020 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-author A reviewer has asked the author a question or requested changes delegated The PR author may merge after reviewing final suggestions. easy < 20s of review time. See the lifecycle page for guidelines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants