Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(archive/imo): formalize 1987Q1 #4731

Closed
wants to merge 3 commits into from

Conversation

urkud
Copy link
Member

@urkud urkud commented Oct 22, 2020


I have a sorry-free proof of the problem. Formalizing it motivated me to add equiv.set.compl. Finalizing this PR is a very low priority task in my TODO list. If someone else wants to do it, then feel free to take over.

@urkud urkud added needs-documentation This PR is missing required documentation please-adopt This PR/issue may have been abandoned by the original contributor. You are welcome to take it over. imo Formalisation of an IMO problem labels Oct 22, 2020
urkud added a commit that referenced this pull request Oct 22, 2020
* fix universe levels in `equiv.set.compl`: by default Lean uses some
`max` universes both for `α` and `β`, and it backfires when one tries
to apply it.

* add `nat.mul_factorial_pred`;

* add instance `fixed_points.decidable`.

Part of #4731
bors bot pushed a commit that referenced this pull request Oct 22, 2020
* fix universe levels in `equiv.set.compl`: by default Lean uses some
`max` universes both for `α` and `β`, and it backfires when one tries
to apply it.

* add `nat.mul_factorial_pred`;

* add instance `fixed_points.decidable`.

Part of #4731
@github-actions github-actions bot added the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Jan 27, 2021
@github-actions github-actions bot removed the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Feb 8, 2021
@urkud urkud added awaiting-review The author would like community review of the PR and removed needs-documentation This PR is missing required documentation please-adopt This PR/issue may have been abandoned by the original contributor. You are welcome to take it over. labels Feb 8, 2021
Copy link
Collaborator

@bryangingechen bryangingechen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise, LGTM.

archive/imo/imo1987_q1.lean Outdated Show resolved Hide resolved
archive/imo/imo1987_q1.lean Outdated Show resolved Hide resolved
archive/imo/imo1987_q1.lean Outdated Show resolved Hide resolved
Co-authored-by: Bryan Gin-ge Chen <bryangingechen@gmail.com>
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Feb 10, 2021
bors bot pushed a commit that referenced this pull request Feb 11, 2021
@bors
Copy link

bors bot commented Feb 11, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(archive/imo): formalize 1987Q1 [Merged by Bors] - feat(archive/imo): formalize 1987Q1 Feb 11, 2021
@bors bors bot closed this Feb 11, 2021
@bors bors bot deleted the imo1987-q1 branch February 11, 2021 04:10
jcommelin pushed a commit that referenced this pull request Feb 11, 2021
b-mehta pushed a commit that referenced this pull request Apr 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
imo Formalisation of an IMO problem ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants