-
Notifications
You must be signed in to change notification settings - Fork 299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat(archive/imo): formalize 1987Q1 #4731
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
urkud
added
needs-documentation
This PR is missing required documentation
please-adopt
This PR/issue may have been abandoned by the original contributor. You are welcome to take it over.
imo
Formalisation of an IMO problem
labels
Oct 22, 2020
urkud
added a commit
that referenced
this pull request
Oct 22, 2020
* fix universe levels in `equiv.set.compl`: by default Lean uses some `max` universes both for `α` and `β`, and it backfires when one tries to apply it. * add `nat.mul_factorial_pred`; * add instance `fixed_points.decidable`. Part of #4731
bors bot
pushed a commit
that referenced
this pull request
Oct 22, 2020
* fix universe levels in `equiv.set.compl`: by default Lean uses some `max` universes both for `α` and `β`, and it backfires when one tries to apply it. * add `nat.mul_factorial_pred`; * add instance `fixed_points.decidable`. Part of #4731
github-actions
bot
added
the
merge-conflict
Please `git merge origin/master` then a bot will remove this label.
label
Jan 27, 2021
github-actions
bot
removed
the
merge-conflict
Please `git merge origin/master` then a bot will remove this label.
label
Feb 8, 2021
urkud
added
awaiting-review
The author would like community review of the PR
and removed
needs-documentation
This PR is missing required documentation
please-adopt
This PR/issue may have been abandoned by the original contributor. You are welcome to take it over.
labels
Feb 8, 2021
bryangingechen
approved these changes
Feb 9, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise, LGTM.
Co-authored-by: Bryan Gin-ge Chen <bryangingechen@gmail.com>
jcommelin
approved these changes
Feb 10, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 🎉
bors merge
github-actions
bot
added
ready-to-merge
All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
and removed
awaiting-review
The author would like community review of the PR
labels
Feb 10, 2021
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
feat(archive/imo): formalize 1987Q1
[Merged by Bors] - feat(archive/imo): formalize 1987Q1
Feb 11, 2021
jcommelin
pushed a commit
that referenced
this pull request
Feb 11, 2021
b-mehta
pushed a commit
that referenced
this pull request
Apr 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
imo
Formalisation of an IMO problem
ready-to-merge
All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a sorry-free proof of the problem. Formalizing it motivated me to add
equiv.set.compl
. Finalizing this PR is a very low priority task in my TODO list. If someone else wants to do it, then feel free to take over.