Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - refactor(data/polynomial): use linear_map for monomial, review degree #4784

Closed
wants to merge 16 commits into from
Closed

[Merged by Bors] - refactor(data/polynomial): use linear_map for monomial, review degree #4784

wants to merge 16 commits into from

Conversation

urkud
Copy link
Member

@urkud urkud commented Oct 26, 2020 •
edited by github-actions bot

@urkud urkud added the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Oct 26, 2020
@bryangingechen bryangingechen added awaiting-review The author would like community review of the PR and removed blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. labels Oct 26, 2020
@urkud urkud mentioned this pull request Oct 27, 2020
Closed
@jcommelin
Copy link
Member

Thanks 🎉

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) merge-conflict Please `git merge origin/master` then a bot will remove this label. and removed awaiting-review The author would like community review of the PR labels Oct 27, 2020
@bryangingechen
Copy link
Collaborator

merge conflict
bors r-

@bors
Copy link

bors bot commented Oct 27, 2020

Canceled.

@bryangingechen bryangingechen added awaiting-author A reviewer has asked the author a question or requested changes and removed ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) labels Oct 27, 2020
@github-actions github-actions bot removed the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Oct 27, 2020
@urkud urkud added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Oct 27, 2020
@bryangingechen
Copy link
Collaborator

I guess you're waiting on the build to succeed? In any case:
bors d+

@bors
Copy link

bors bot commented Oct 27, 2020

✌️ urkud can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@bryangingechen bryangingechen added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Oct 27, 2020
@urkud
Copy link
Member Author

urkud commented Oct 27, 2020

bors merge

@github-actions github-actions bot added the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label Oct 27, 2020
@bryangingechen bryangingechen mentioned this pull request Oct 27, 2020
Closed
bors bot pushed a commit that referenced this pull request Oct 27, 2020
@riccardobrasca @urkud
refactor(data/polynomial): use linear_map for monomial, review `d…
97065db 
…egree` (#4784)

Co-authored-by: Yury G. Kudryashov <urkud@urkud.name>
@bors
Copy link

bors bot commented Oct 27, 2020

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title refactor(data/polynomial): use linear_map for monomial, review degree [Merged by Bors] - refactor(data/polynomial): use linear_map for monomial, review degree Oct 27, 2020
@bors bors bot closed this Oct 27, 2020
@bors bors bot deleted the bundled-monomial branch October 27, 2020 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-wieser eric-wieser eric-wieser left review comments

Assignees
No one assigned
Labels
delegated The PR author may merge after reviewing final suggestions. ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@urkud @jcommelin @bryangingechen @eric-wieser @riccardobrasca