Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(algebra/algebra/subalgebra): algebra equalizer #4791

Closed
wants to merge 5 commits into from
Closed

[Merged by Bors] - feat(algebra/algebra/subalgebra): algebra equalizer #4791

wants to merge 5 commits into from

Conversation

tb65536
Copy link
Collaborator

@tb65536 tb65536 commented Oct 26, 2020

Changes to subalgebra.lean from #4786

@tb65536 tb65536 mentioned this pull request Oct 26, 2020
Closed
7 tasks
jcommelin
jcommelin requested changes Oct 26, 2020
View reviewed changes
src/algebra/algebra/subalgebra.lean Outdated Show resolved Hide resolved
@jcommelin jcommelin added the awaiting-author A reviewer has asked the author a question or requested changes label Oct 26, 2020
@tb65536 @jcommelin
Update src/algebra/algebra/subalgebra.lean
e00bc89 
Co-authored-by: Johan Commelin <johan@commelin.net>
@tb65536 tb65536 added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Oct 26, 2020
@jcommelin jcommelin added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Oct 27, 2020
@bryangingechen bryangingechen changed the title feat(subalgebra.lean): Algebra Equalizer feat(algebra/algebra/subalgebra): Algebra Equalizer Oct 27, 2020
@tb65536 tb65536 added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Oct 27, 2020
@jcommelin jcommelin changed the title feat(algebra/algebra/subalgebra): Algebra Equalizer feat(algebra/algebra/subalgebra): algebra equalizer Oct 27, 2020
@jcommelin
Copy link
Member

bors d+

@bors
Copy link

bors bot commented Oct 27, 2020

✌️ tb65536 can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@tb65536 @jcommelin
Update src/algebra/algebra/subalgebra.lean
395e87b 
Co-authored-by: Johan Commelin <johan@commelin.net>
@tb65536
Copy link
Collaborator Author

tb65536 commented Oct 27, 2020

✌️ tb65536 can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

bors r+

@tb65536
Copy link
Collaborator Author

tb65536 commented Oct 27, 2020

bors r+

@bors
Copy link

bors bot commented Oct 27, 2020

Already running a review

@bryangingechen
Copy link
Collaborator

@tb65536 bors doesn't acknowledge when it puts things on the queue, other than adding an entry to the status checks showing "bors Pending - Waiting in queue". You should also be able to check the queue here.

bors bot pushed a commit that referenced this pull request Oct 27, 2020
@tb65536
feat(algebra/algebra/subalgebra): algebra equalizer (#4791)
c737996 
Changes to subalgebra.lean from #4786



Co-authored-by: tb65536 <tb65536@users.noreply.github.com>
@bors
Copy link

bors bot commented Oct 28, 2020

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(algebra/algebra/subalgebra): algebra equalizer [Merged by Bors] - feat(algebra/algebra/subalgebra): algebra equalizer Oct 28, 2020
@bors bors bot closed this Oct 28, 2020
@bors bors bot deleted the algebra_equalizer branch October 28, 2020 00:54
@YaelDillies YaelDillies removed the awaiting-review The author would like community review of the PR label Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tb65536 @jcommelin @bryangingechen @YaelDillies