Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(analysis/inner_product_space/of_norm): Create an inner product from a norm #4798

Closed
wants to merge 30 commits into from

Conversation

hrmacbeth
Copy link
Member

@hrmacbeth hrmacbeth commented Oct 27, 2020

A normed space respecting the polarization identity is an inner product space.

Co-authored-by: Frédéric Dupuis dupuisf@iro.umontreal.ca
Co-authored-by: Ruben Van de Velde 65514131+Ruben-VandeVelde@users.noreply.github.com


The idea will be to show that with this definition the dual space is indeed an inner product space. But many purely algebraic calculations remain, so this is WIP until I, Frédéric or any other volunteer has time to try them.

Separated out from #4379 (but independent of it). Discussion at
https://leanprover.zulipchat.com/#narrow/stream/217875-Is-there.20code.20for.20X.3F/topic/Hilbert.20space.20is.20isometric.20to.20its.20dual

@hrmacbeth hrmacbeth added the WIP Work in progress label Oct 27, 2020
@hrmacbeth hrmacbeth changed the title feat(analysis.normed_space.dual): dual inner product space feat(analysis/normed_space/dual): dual inner product space Oct 27, 2020
@dupuisf
Copy link
Collaborator

dupuisf commented Nov 6, 2020

@hrmacbeth For parallelogram_law_with_dual_norm, wouldn't it follow from the fact that the dual is isomorphic to the completion of E?

@github-actions github-actions bot added the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Nov 23, 2020
@Ruben-VandeVelde Ruben-VandeVelde removed the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Aug 26, 2022
@Ruben-VandeVelde
Copy link
Collaborator

@hrmacbeth I finished inner_product_space.of_norm (moving it to a separate file), and dropped parallelogram_law_with_dual_norm for lack of a proof. Do you think it's ready for review now?

@Ruben-VandeVelde Ruben-VandeVelde added awaiting-review The author would like community review of the PR and removed WIP Work in progress labels Nov 17, 2022
Copy link
Collaborator

@sgouezel sgouezel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The title of the PR has nothing to do with its content, right?

src/analysis/inner_product_space/of_norm.lean Outdated Show resolved Hide resolved
src/analysis/inner_product_space/of_norm.lean Outdated Show resolved Hide resolved
# Inner product space derived from a norm

This file defines an `inner_product_space` instance from a norm that respects the
parallellogram identity.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you recall here what the parallelogram identity is? And maybe sketch the proof you will be giving somewhere in the file-level docstring, with pointers to intermediate lemmas in the proof.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've recalled what the parallelogram identity is, but I can't link to intermediate lemmas because we're making them private.

@sgouezel sgouezel added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Nov 24, 2022
@@ -0,0 +1,407 @@
/-
Copyright (c) 2020 Heather Macbeth. All rights reserved.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2020??!!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Zombie PR, revived by Ruben :)

@YaelDillies YaelDillies changed the title feat(analysis/normed_space/dual): dual inner product space feat(analysis/inner_product_space/of_norm): Create an inner product from a norm Feb 28, 2023
Comment on lines +49 to +51
4⁻¹ * ((𝓚 ‖x + y‖) * (𝓚 ‖x + y‖) - (𝓚 ‖x - y‖) * (𝓚 ‖x - y‖)
+ (I:𝕜) * (𝓚 ‖(I:𝕜) • x + y‖) * (𝓚 ‖(I:𝕜) • x + y‖)
- (I:𝕜) * (𝓚 ‖(I:𝕜) • x - y‖) * (𝓚 ‖(I:𝕜) • x - y‖))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this generalize as an approach to producing a conjugate-linear map over any star ring? My guess would be that summing over the generators does the trick...

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know much about star rings. Can you detail? How are the generators denoted in mathlib?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess what I probably meant here is "over the quaternions".

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably you're right, but I have no idea how to do it in Lean. You will need to give me more info.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I should be clear that this comment is not intended to block this PR

@mcdoll
Copy link
Member

mcdoll commented Jun 8, 2023

Apart from the merge-conflict this should be good, right? @Ruben-VandeVelde

@Ruben-VandeVelde Ruben-VandeVelde added the awaiting-CI The author would like to see what CI has to say before doing more work. label Jun 14, 2023
@github-actions github-actions bot removed the awaiting-CI The author would like to see what CI has to say before doing more work. label Jun 15, 2023
@Ruben-VandeVelde
Copy link
Collaborator

Apart from the merge-conflict this should be good, right? @Ruben-VandeVelde

Certainly as far as I'm concerned

@urkud
Copy link
Member

urkud commented Jun 21, 2023

LGTM modulo adding a sketch of the proof to the module docstring. Thank you!
bors d+

@bors
Copy link

bors bot commented Jun 21, 2023

✌️ hrmacbeth can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Jun 21, 2023
@YaelDillies
Copy link
Collaborator

Yury, did you mean to delegate to Heather? She's been inactive on that PR for 2 years and a half.

@kmill
Copy link
Collaborator

kmill commented Jul 12, 2023

Wow, a PR with an id that's less than the current Mathlib4 PRs :-)

bors r+

@github-actions github-actions bot added the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label Jul 12, 2023
bors bot pushed a commit that referenced this pull request Jul 12, 2023
…rom a norm (#4798)

A normed space respecting the polarization identity is an inner product space.

Co-authored-by: Frédéric Dupuis <dupuisf@iro.umontreal.ca>
Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>



Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
@bors
Copy link

bors bot commented Jul 12, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat(analysis/inner_product_space/of_norm): Create an inner product from a norm [Merged by Bors] - feat(analysis/inner_product_space/of_norm): Create an inner product from a norm Jul 12, 2023
@bors bors bot closed this Jul 12, 2023
@bors bors bot deleted the inner_product_space_dual branch July 12, 2023 23:18
Ruben-VandeVelde added a commit to leanprover-community/mathlib4 that referenced this pull request Jul 14, 2023
bors bot pushed a commit to leanprover-community/mathlib4 that referenced this pull request Jul 14, 2023
kbuzzard pushed a commit to leanprover-community/mathlib4 that referenced this pull request Jul 15, 2023
semorrison pushed a commit to leanprover-community/mathlib4 that referenced this pull request Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated The PR author may merge after reviewing final suggestions. modifies-synchronized-file This PR touches a files that has already been ported to mathlib4, and may need a synchronization PR. ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) t-analysis Analysis (normed *, calculus)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants