Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(field_theory/adjoin): Adjoin integral element #4831

Closed
wants to merge 65 commits into from
Closed

[Merged by Bors] - feat(field_theory/adjoin): Adjoin integral element #4831

wants to merge 65 commits into from

Conversation

tb65536
Copy link
Collaborator

@tb65536 tb65536 commented Oct 30, 2020 •
edited by github-actions bot

@tb65536 tb65536 mentioned this pull request Oct 30, 2020
Closed
7 tasks
@jcommelin
Copy link
Member

  • Please add the top-level directory to the PR title: feat(field_theory/adjoin): ...
  • Use the template to record dependent PRs. If you use that format, a bot will help us tick them off.
  • Please use the awaiting-review and blocked-by-other-PR where appropriate.

@tb65536 tb65536 added awaiting-review The author would like community review of the PR blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. labels Oct 30, 2020
@tb65536 tb65536 changed the title feat(adjoin.lean): Adjoin integral element feat(field_theory/adjoin.lean): Adjoin integral element Oct 30, 2020
@tb65536 tb65536 removed the awaiting-review The author would like community review of the PR label Oct 30, 2020
@tb65536
Copy link
Collaborator Author

tb65536 commented Oct 30, 2020

  • Please add the top-level directory to the PR title: feat(field_theory/adjoin): ...
  • Use the template to record dependent PRs. If you use that format, a bot will help us tick them off.
  • Please use the awaiting-review and blocked-by-other-PR where appropriate.

Should a PR that doesn't compile (due to being dependent on other PR's) be marked as awaiting review?

@jcommelin jcommelin changed the title feat(field_theory/adjoin.lean): Adjoin integral element feat(field_theory/adjoin): Adjoin integral element Oct 30, 2020
@tb65536 tb65536 added the awaiting-review The author would like community review of the PR label Oct 30, 2020
tb65536 and others added 16 commits October 30, 2020 00:17
@tb65536
fintype instance
92f1644
@tb65536
to_finset_card_of_nodup
0768037
@jcommelin
Merge branch 'master' into galois/polynomial
a4fb0cb
@jcommelin
restate equiv in terms of fin n, compress proofs
ecb31af
@tb65536
golfed a bit
01f276f
@tb65536
Merge remote-tracking branch 'origin/galois/polynomial' into galois/a…
0cdedb6 
…djoin_root

merge
@tb65536
Merge remote-tracking branch 'origin/galois/adjoin_root' into galois/…
e9f27e4 
…adjoin

merge
@tb65536
fix error
9ac5fe6
@tb65536
Merge remote-tracking branch 'origin/galois/adjoin_root' into galois/…
b2d113e 
…adjoin

merge
@tb65536
bad simp?
c20da0b
@tb65536
Merge remote-tracking branch 'origin/galois/polynomial' into galois/a…
895f65e 
…djoin_root

merge
@tb65536
Merge remote-tracking branch 'origin/galois/adjoin_root' into galois/…
3e56b86 
…adjoin

merge
@tb65536
generalize slightly
e60fca9
@tb65536
remove duplicate hypothesis
a5d220c
@jcommelin
unrefined
0bb2b74
@tb65536
Merge remote-tracking branch 'origin/galois/polynomial' into galois/a…
d8c428a 
…djoin_root

merge
@github-actions github-actions bot added the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Nov 11, 2020
@github-actions github-actions bot removed the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Nov 11, 2020
@tb65536 tb65536 removed the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Nov 11, 2020
Vierkantor
Vierkantor requested changes Nov 12, 2020
View reviewed changes
src/field_theory/adjoin.lean Show resolved Hide resolved
src/field_theory/adjoin.lean Outdated Show resolved Hide resolved
src/field_theory/adjoin.lean Outdated Show resolved Hide resolved
src/field_theory/adjoin.lean Outdated Show resolved Hide resolved
src/field_theory/adjoin.lean Show resolved Hide resolved
@Vierkantor Vierkantor added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Nov 12, 2020
@Vierkantor Vierkantor mentioned this pull request Nov 12, 2020
Closed
tb65536 and others added 3 commits November 12, 2020 09:37
@tb65536 @Vierkantor
Update src/field_theory/adjoin.lean
a51cd1e 
Co-authored-by: Anne Baanen <Vierkantor@users.noreply.github.com>
@tb65536 @Vierkantor
Update src/field_theory/adjoin.lean
054eced 
Co-authored-by: Anne Baanen <Vierkantor@users.noreply.github.com>
@tb65536 @Vierkantor
Update src/field_theory/adjoin.lean
ea9f231 
Co-authored-by: Anne Baanen <Vierkantor@users.noreply.github.com>
@tb65536 tb65536 added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Nov 12, 2020
Vierkantor
Vierkantor approved these changes Nov 13, 2020
View reviewed changes
Copy link
Collaborator

@Vierkantor Vierkantor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🎉

bors d+

src/field_theory/adjoin.lean Show resolved Hide resolved
src/field_theory/adjoin.lean Outdated Show resolved Hide resolved
@bors
Copy link

bors bot commented Nov 13, 2020

✌️ tb65536 can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@tb65536 @Vierkantor
Update src/field_theory/adjoin.lean
9f641b2 
Co-authored-by: Anne Baanen <Vierkantor@users.noreply.github.com>
@tb65536
Copy link
Collaborator Author

tb65536 commented Nov 13, 2020

bors r+

bors bot pushed a commit that referenced this pull request Nov 13, 2020
@tb65536 @jcommelin
feat(field_theory/adjoin): Adjoin integral element (#4831)
050b837 


Co-authored-by: Johan Commelin <johan@commelin.net>
Co-authored-by: tb65536 <tb65536@users.noreply.github.com>
@bors
Copy link

bors bot commented Nov 13, 2020

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(field_theory/adjoin): Adjoin integral element [Merged by Bors] - feat(field_theory/adjoin): Adjoin integral element Nov 13, 2020
@bors bors bot closed this Nov 13, 2020
@bors bors bot deleted the galois/adjoin branch November 13, 2020 22:06
@YaelDillies YaelDillies removed the awaiting-review The author would like community review of the PR label Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin left review comments

@Vierkantor Vierkantor Vierkantor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tb65536 @jcommelin @Vierkantor @YaelDillies