-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat(ring_theory/witt_vector/mul_p): multiplication by p as operation on witt vectors #4837
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, the only issue is that the proofs take so long. Do you have any idea to fix that?
Co-authored-by: Anne Baanen <Vierkantor@users.noreply.github.com>
It seems to me that lean is also taking a long time to simply elaborate the statements. E.g. comment out the proof of |
Some profiling shows that the |
Co-authored-by: Anne Baanen <Vierkantor@users.noreply.github.com>
Thanks! It's still a bit slow but not painfully so anymore. bors r+ |
… on witt vectors (#4837) Co-Authored-By: Rob Y. Lewis <rob.y.lewis@gmail.com>
Pull request successfully merged into master. Build succeeded: |
Co-Authored-By: Rob Y. Lewis rob.y.lewis@gmail.com