Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(ring_theory/witt_vector/mul_p): multiplication by p as operation on witt vectors #4837

Closed
wants to merge 4 commits into from

Conversation

jcommelin
Copy link
Member

Co-Authored-By: Rob Y. Lewis rob.y.lewis@gmail.com


@jcommelin jcommelin added the awaiting-review The author would like community review of the PR label Oct 30, 2020
Copy link
Collaborator

@Vierkantor Vierkantor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, the only issue is that the proofs take so long. Do you have any idea to fix that?

src/ring_theory/witt_vector/mul_p.lean Outdated Show resolved Hide resolved
src/ring_theory/witt_vector/mul_p.lean Outdated Show resolved Hide resolved
src/ring_theory/witt_vector/mul_p.lean Outdated Show resolved Hide resolved
jcommelin and others added 2 commits November 9, 2020 13:44
Co-authored-by: Anne Baanen <Vierkantor@users.noreply.github.com>
@jcommelin
Copy link
Member Author

It seems to me that lean is also taking a long time to simply elaborate the statements. E.g. comment out the proof of witt_mul_n_coeff of mul_n_is_poly.

@Vierkantor
Copy link
Collaborator

Some profiling shows that the exactI tactic in the statement takes 2s! It looks like the local attribute [semireducible] witt_vector is the culprit, removing it halves the compilation time (time lean src/ring_theory/witt_vector/mul_p.lean goes from 8.7s to 4.3s).

Co-authored-by: Anne Baanen <Vierkantor@users.noreply.github.com>
@Vierkantor
Copy link
Collaborator

Thanks! It's still a bit slow but not painfully so anymore.

bors r+

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Nov 10, 2020
bors bot pushed a commit that referenced this pull request Nov 10, 2020
… on witt vectors (#4837)

Co-Authored-By: Rob Y. Lewis <rob.y.lewis@gmail.com>
@bors
Copy link

bors bot commented Nov 10, 2020

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(ring_theory/witt_vector/mul_p): multiplication by p as operation on witt vectors [Merged by Bors] - feat(ring_theory/witt_vector/mul_p): multiplication by p as operation on witt vectors Nov 10, 2020
@bors bors bot closed this Nov 10, 2020
@bors bors bot deleted the witt-mul-p branch November 10, 2020 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants