[Merged by Bors] - feat(category_theory/limits/preserves/shapes/products): preserve products #4857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b-mehta
added
awaiting-review
github-actions
bot
added
the
merge-conflict
github-actions
bot
removed
the
merge-conflict
b-mehta
removed
the
blocked-by-other-PR
|
I'm not super happy with the module doc here, suggestions for what else to add would be appreciated. This is the exact same as the equalizers version I mentioned in #4716 |
jcommelin
approved these changes
Nov 7, 2020
|
Thanks 🎉 bors merge |
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Nov 7, 2020
…ducts (#4857) A smaller part of #4716, for just products. This also renames the file `preserves/shapes.lean` to `preserves/shapes/products.lean`, since I want a similar API for other special shapes and it'd get too big otherwise. Of the declarations which were already present: `preserves_products_iso`, `preserves_products_iso_hom_π`, `map_lift_comp_preserves_products_iso_hom`, the first is still there but with weaker assumptions, and the other two are now provable by simp (under weaker assumptions again).
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
b-mehta
added a commit
that referenced
this pull request
Nov 12, 2020
…ducts (#4857) A smaller part of #4716, for just products. This also renames the file `preserves/shapes.lean` to `preserves/shapes/products.lean`, since I want a similar API for other special shapes and it'd get too big otherwise. Of the declarations which were already present: `preserves_products_iso`, `preserves_products_iso_hom_π`, `map_lift_comp_preserves_products_iso_hom`, the first is still there but with weaker assumptions, and the other two are now provable by simp (under weaker assumptions again).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A smaller part of #4716, for just products.
This also renames the file
preserves/shapes.leantopreserves/shapes/products.lean, since I want a similar API for other special shapes and it'd get too big otherwise.Of the declarations which were already present:
preserves_products_iso,preserves_products_iso_hom_π,map_lift_comp_preserves_products_iso_hom, the first is still there but with weaker assumptions, and the other two are now provable by simp (under weaker assumptions again).