[Merged by Bors] - feat(tactic/mk_iff_of_inductive_prop): mk_iff attribute #4863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryangingechen
added
awaiting-review
bryangingechen
commented
Nov 1, 2020
bryangingechen
commented
Nov 1, 2020
bryangingechen
commented
Nov 1, 2020
robertylewis
reviewed
Nov 1, 2020
robertylewis
added
awaiting-author
bryangingechen
commented
Nov 1, 2020
Comment on lines
+56
to
57
| @[nolint doc_blame] -- TODO: document | ||
| meta def constr_to_prop (univs : list level) (g : list expr) (idxs : list expr) (c : name) : |
There was a problem hiding this comment.
Any docstring suggestions?
Comment on lines
+90
to
+91
| @[nolint doc_blame] -- TODO: document | ||
| meta def to_cases (s : list $ list (option expr) × (expr ⊕ ℕ)) : tactic unit := |
There was a problem hiding this comment.
Any docstring suggestions?
There was a problem hiding this comment.
These will take some studying to figure out, and I don't think we'll get the original author to chime in. I don't mind leaving it nolinted for now, and doing that studying if and when it's necessary.
There was a problem hiding this comment.
OK, fair enough. I'd be OK merging this for now then.
Comment on lines
+125
to
128
| @[nolint doc_blame] -- TODO: document | ||
| meta def to_inductive | ||
| (cs : list name) (gs : list expr) (s : list (list (option expr) × (expr ⊕ ℕ))) (h : expr) : | ||
| tactic unit := |
There was a problem hiding this comment.
Any docstring suggestions?
bryangingechen
added
awaiting-review
|
bors merge |
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Nov 3, 2020
This attribute should make `mk_iff_of_inductive_prop` easier to use.
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This attribute should make
mk_iff_of_inductive_propeasier to use.Should
mk_iffget some more config options?Zulip thread.