[Merged by Bors] - feat(data/matrix): little lemmas on map
#4874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I had a couple of expressions involving `matrix.map` that the simplifier didn't `simp` away. It turns out the missing lemmas already existed, just not with the correct form / hypotheses. So here they are.
Vierkantor
added
the
awaiting-review
Co-authored-by: Bryan Gin-ge Chen <bryangingechen@gmail.com>
eric-wieser
reviewed
Nov 2, 2020
|
What's the status of this PR? Was there a conclusion from the Zulip discussion linked above? |
|
There wasn't really a conclusion, unfortunately. A big refactor like that seems out of scope for this small PR anyway, so I'll put it on my todo list for another time and add the specialized lemmas in the suggestion for now. |
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
eric-wieser
reviewed
Nov 9, 2020
eric-wieser
reviewed
Nov 9, 2020
eric-wieser
reviewed
Nov 9, 2020
eric-wieser
reviewed
Nov 9, 2020
| @@ -353,6 +353,54 @@ lemma map_mul {L : matrix m n α} {M : matrix n o α} | |||
| (L ⬝ M).map f = L.map f ⬝ M.map f := | |||
| by { ext, simp [mul_apply, ring_hom.map_sum], } | |||
|
|
|||
| /-- A version of `one_map` where `f` is a ring hom. -/ | |||
There was a problem hiding this comment.
Perhaps:
Suggested change
| /-- A version of `one_map` where `f` is a ring hom. -/ | |
| /-! | |
| Variants of `one_map` and `zero_map` for each of the many bundled homs and equivs. | |
| This hopefully won't be necessary [in future](https://leanprover.zulipchat.com/#narrow/stream/113488-general/topic/Typeclasses.20for.20morphisms) | |
| -/ | |
| /-- A version of `one_map` where `f` is a ring hom. -/ |
or some other "this is a mess that we know about and should be discussed here" comment.
eric-wieser
reviewed
Nov 9, 2020
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
…ight `simp` lemmas
|
I'm happy with merging this PR and creating an issue (maybe this is already done) with the ideas for the big refactor. |
eric-wieser
reviewed
Nov 10, 2020
|
Fine with this too, especially since @Vierkantor has gone to the effort of covering all the homs in this PR. |
Vierkantor
commented
Nov 10, 2020
Vierkantor
commented
Nov 10, 2020
bryangingechen
approved these changes
Nov 11, 2020
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Nov 12, 2020
I had a couple of expressions involving mapping matrices, that the simplifier didn't `simp` away. It turns out the missing lemmas already existed, just not with the correct form / hypotheses. So here they are. Co-authored-by: Anne Baanen <Vierkantor@users.noreply.github.com>
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
mapmap
|
This was essentially reverted in #8512 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had a couple of expressions involving mapping matrices, that the simplifier didn't
simpaway. It turns out the missing lemmas already existed, just not with the correct form / hypotheses. So here they are.