Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(category_theory/limits/types): explicit description of equalizers in Type #4880

Closed
wants to merge 2 commits into from

Conversation

b-mehta
Copy link
Collaborator

@b-mehta b-mehta commented Nov 2, 2020

Cf https://leanprover.zulipchat.com/#narrow/stream/217875-Is-there.20code.20for.20X.3F/topic/concrete.20limits.20in.20Type.

Adds equivalent conditions for a fork in Type to be a equalizer, and a proof that the subtype is an equalizer.

(cc: @adamtopaz @kbuzzard)


@b-mehta b-mehta added easy < 20s of review time. See the lifecycle page for guidelines. awaiting-review The author would like community review of the PR labels Nov 2, 2020
@kbuzzard
Copy link
Member

kbuzzard commented Nov 2, 2020

Very nice! I think this is a worthwhile addition -- given that are are currently limited to sheaves of types, it's good to get some tools which can handle conditions related to sheaves of types like being an equalizer.

Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Nov 3, 2020
bors bot pushed a commit that referenced this pull request Nov 3, 2020
@bors
Copy link

bors bot commented Nov 3, 2020

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(category_theory/limits/types): explicit description of equalizers in Type [Merged by Bors] - feat(category_theory/limits/types): explicit description of equalizers in Type Nov 3, 2020
@bors bors bot closed this Nov 3, 2020
@bors bors bot deleted the type-equalizer branch November 3, 2020 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants