[Merged by Bors] - feat(algebra/star): star monoids, rings and algebras #4886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
eric-wieser
added
the
awaiting-review
eric-wieser
force-pushed
the
eric-wieser/star-ring
branch
from
271c1f0
to
26117cf
Compare
eric-wieser
force-pushed
the
eric-wieser/star-ring
branch
from
26117cf
to
ea651b4
Compare
jcommelin
reviewed
Nov 3, 2020
eric-wieser
commented
Nov 3, 2020
eric-wieser
commented
Nov 3, 2020
1 task
|
Once this goes in, I'll add some instances for |
eric-wieser
commented
Nov 4, 2020
Co-authored-by: Bryan Gin-ge Chen <bryangingechen@gmail.com>
|
Thanks @bryangingechen, updated |
github-actions
bot
added
the
merge-conflict
jcommelin
approved these changes
Nov 14, 2020
|
✌️ eric-wieser can now approve this pull request. To approve and merge a pull request, simply reply with |
github-actions
bot
removed
the
merge-conflict
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Nov 15, 2020
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
4 tasks
YaelDillies
removed
the
awaiting-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This takes the parts of #4685 and #4686 which do not concern themselves with
ordering, thus removing the dependency on a stale PR. I don't expect this to cause any difficult merge conflicts if this goes in before the other two,as the lines have been copied without modification.Changes made on top of Scott's work:
_equivstructures