Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(data/set/intervals/basic): collection of lemmas of the form I??_of_I?? #4918

Closed
wants to merge 2 commits into from

Conversation

benjamindavidson
Copy link
Collaborator

Some propositions about intervals that I thought may be useful (despite their simplicity).

@urkud
Copy link
Member

urkud commented Nov 6, 2020

What's the added value compared to the RHS?

@benjamindavidson
Copy link
Collaborator Author

Admittedly, while these lemmas are not definitively "better" than the lemmas used to prove them, and I would understand if they were deemed not worth being added to mathlib, I feel that their usefulness comes from the fact that their RHS are not necessarily obvious choices for their proofs; in fact, library_search does not generate them. These lemmas do show up in a library_search and also provide some consistency - I think of them as to intervals what le_of_lt is to inequalities.

@urkud urkud added the awaiting-review The author would like community review of the PR label Nov 6, 2020
@benjamindavidson benjamindavidson added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Nov 7, 2020
@benjamindavidson benjamindavidson added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-author A reviewer has asked the author a question or requested changes labels Nov 7, 2020
@bryangingechen bryangingechen added awaiting-review The author would like community review of the PR and removed ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) labels Nov 8, 2020
@bryangingechen
Copy link
Collaborator

@benjamindavidson The "ready-to-merge" label means that the PR has been put on the queue to be merged; usually it's added automatically by some GitHub actions scripts. The "awaiting-review" label will put the PR on the maintainers' radar.

@bryangingechen
Copy link
Collaborator

Actually, in this case, I see from the discussion that this should be ready to go, so I'll approve it. Thanks for the contribution!

bors r+

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Nov 8, 2020
bors bot pushed a commit that referenced this pull request Nov 8, 2020
…of_I?? (#4918)

Some propositions about intervals that I thought may be useful (despite their simplicity).
@bors
Copy link

bors bot commented Nov 8, 2020

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(data/set/intervals/basic): collection of lemmas of the form I??_of_I?? [Merged by Bors] - feat(data/set/intervals/basic): collection of lemmas of the form I??_of_I?? Nov 8, 2020
@bors bors bot closed this Nov 8, 2020
@bors bors bot deleted the intervals branch November 8, 2020 21:08
benjamindavidson added a commit that referenced this pull request Nov 9, 2020
…of_I?? (#4918)

Some propositions about intervals that I thought may be useful (despite their simplicity).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants