Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(category_theory/closed): cartesian closed category with zero object is trivial #4924

Closed
wants to merge 3 commits into from
Closed

[Merged by Bors] - feat(category_theory/closed): cartesian closed category with zero object is trivial #4924

wants to merge 3 commits into from

Conversation

b-mehta
Copy link
Collaborator

@b-mehta b-mehta commented Nov 6, 2020

@b-mehta b-mehta added the awaiting-review The author would like community review of the PR label Nov 6, 2020
@jcommelin
Copy link
Member

Please add docstrings. Otherwise, this looks good.

@jcommelin jcommelin added awaiting-author A reviewer has asked the author a question or requested changes needs-documentation This PR is missing required documentation and removed awaiting-review The author would like community review of the PR labels Nov 7, 2020
@b-mehta b-mehta added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes needs-documentation This PR is missing required documentation labels Nov 7, 2020
jcommelin
jcommelin approved these changes Nov 10, 2020
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Nov 10, 2020
bors bot pushed a commit that referenced this pull request Nov 10, 2020
@b-mehta
feat(category_theory/closed): cartesian closed category with zero obj…
ecbcd38 
…ect is trivial (#4924)
@bors
Copy link

bors bot commented Nov 10, 2020

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(category_theory/closed): cartesian closed category with zero object is trivial [Merged by Bors] - feat(category_theory/closed): cartesian closed category with zero object is trivial Nov 10, 2020
@bors bors bot closed this Nov 10, 2020
@bors bors bot deleted the cc-zero branch November 10, 2020 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bryangingechen bryangingechen bryangingechen left review comments

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@b-mehta @jcommelin @bryangingechen