Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(measure_theory/*): a few lemmas about (is_)measurable in Π i, π i #4948

Closed
wants to merge 3 commits into from
Closed

[Merged by Bors] - feat(measure_theory/*): a few lemmas about (is_)measurable in Π i, π i #4948

wants to merge 3 commits into from

Conversation

urkud
Copy link
Member

@urkud urkud commented Nov 8, 2020

@urkud urkud added the awaiting-review The author would like community review of the PR label Nov 8, 2020
@urkud urkud requested a review from fpvandoorn November 8, 2020 15:08
PatrickMassot
PatrickMassot reviewed Nov 8, 2020
View reviewed changes
src/measure_theory/borel_space.lean Outdated Show resolved Hide resolved
src/measure_theory/borel_space.lean Outdated Show resolved Hide resolved
src/measure_theory/measurable_space.lean
@@ -350,19 +350,14 @@ iff.refl _

theorem is_measurable_Sup {ms : set (measurable_space α)} {s : set α} :
@is_measurable _ (Sup ms) s ↔
generate_measurable (⋃₀ (measurable_space.is_measurable' '' ms)) s :=
generate_measurable {s : set α | ∃ m ∈ ms, @is_measurable _ m s} s :=
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the motivation behind this change of statement and the next one?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both changes were made to avoid using set α → Prop as set (set α). Also I think that the new statements save extra rewrites of mem_sUnion/mem_Union both in their proofs, and in lemmas that use them.

@PatrickMassot PatrickMassot added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Nov 8, 2020
urkud and others added 2 commits November 8, 2020 16:12
@urkud @PatrickMassot
Update src/measure_theory/borel_space.lean
c7ab3c9 
Co-authored-by: Patrick Massot <patrickmassot@free.fr>
@urkud
Use constructor
aed6601
@urkud urkud added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Nov 8, 2020
@fpvandoorn
Copy link
Member

LGTM

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Nov 9, 2020
bors bot pushed a commit that referenced this pull request Nov 9, 2020
@urkud
feat(measure_theory/*): a few lemmas about (is_)measurable in `Π i,…
e8758ae 
… π i` (#4948)
@bors
Copy link

bors bot commented Nov 10, 2020

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(measure_theory/*): a few lemmas about (is_)measurable in Π i, π i [Merged by Bors] - feat(measure_theory/*): a few lemmas about (is_)measurable in Π i, π i Nov 10, 2020
@bors bors bot closed this Nov 10, 2020
@bors bors bot deleted the pi-measurable branch November 10, 2020 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PatrickMassot PatrickMassot PatrickMassot left review comments

@fpvandoorn fpvandoorn Awaiting requested review from fpvandoorn

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@urkud @fpvandoorn @PatrickMassot