[Merged by Bors] - chore(algebra/group/defs): Remove shortcut instance definitions #4955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This means that `group.to_left_cancel_semigroup` is now spelt `group.to_cancel_monoid.to_left_cancel_monoid.to_left_cancel_semigroup`. I don't know whether this matters, but this should slightly reduce the number of connections that instance resolution must check
eric-wieser
added
the
awaiting-review
eric-wieser
changed the title
|
@digama0, I think I remember you saying on zulip that these extra "shortcut" diamonds made type resolution slower, not faster? |
|
Sorry for the delayed review, I was very busy yesterday. Mario indeed said shortcut instances are incredibly bad for the algorithm. So this should improve performance a bit. bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Nov 19, 2020
This means that `group.to_left_cancel_semigroup` is now spelt `group.to_cancel_monoid.to_left_cancel_monoid.to_left_cancel_semigroup`. The longer spelling shouldn't actually matter because type inference will do it anyway. I don't know whether this matters, but this should slightly reduce the number of connections that instance resolution must check. This shortcut wasn't added deliberately, it seems it just got added accidentally when #3688 was introduced.
github-actions
bot
added
ready-to-merge
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This means that
group.to_left_cancel_semigroupis now speltgroup.to_cancel_monoid.to_left_cancel_monoid.to_left_cancel_semigroup.The longer spelling shouldn't actually matter because type inference will do it anyway.
I don't know whether this matters, but this should slightly reduce the number of connections that instance resolution must check.
This shortcut wasn't added deliberately, it seems it just got added accidentally when #3688 was introduced.