Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(measure_theory/lp_space): Define Lp spaces #4993

Closed
wants to merge 24 commits into from

Conversation

RemyDegenne
Copy link
Collaborator

Define the space Lp of functions for which the norm raised to the power p has finite integral.
Define the seminorm on that space (without proof that it is a seminorm, for now).

Add three lemmas to analysis/special_functions/pow.lean about ennreal.rpow

@RemyDegenne RemyDegenne added the awaiting-review The author would like community review of the PR label Nov 13, 2020
Copy link
Collaborator

@sgouezel sgouezel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a design question, as I explain in one of the comments: I don't see what use the subtype ℒp would have in the applications (contrary to the subtype Lp of almost everywhere defined functions, which is a normed space and with which one can do analysis) that could not be done as efficiently with the mem_ℒp predicate. Could you explain a little bit why you designed your PR like this?

src/measure_theory/lp_space.lean Outdated Show resolved Hide resolved
src/measure_theory/lp_space.lean Outdated Show resolved Hide resolved
src/measure_theory/lp_space.lean Outdated Show resolved Hide resolved
@sgouezel sgouezel added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Nov 13, 2020
@RemyDegenne
Copy link
Collaborator Author

I have removed the Lp type.
The PR now contains mainly the definition of the mem_LP property and of the quantity snorm, with a first few lemmas relating these two definitions.

@RemyDegenne RemyDegenne added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Nov 14, 2020
@RemyDegenne
Copy link
Collaborator Author

To elaborate on the plan forward: my idea is to first have a sequence of PRs about the properties of mem_Lp, and only then to define the quotient space Lp of functions almost everywhere equal and prove properties of that type (which should be trivial consequences at that point).

Copy link
Collaborator

@sgouezel sgouezel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a lot of minor comments, both about mathlib style and Lean tricks. It's normal, first PRs are always like that (and they are a great occasion to learn). But I am quite happy with the overall content, thanks!

src/measure_theory/lp_space.lean Outdated Show resolved Hide resolved
src/measure_theory/lp_space.lean Outdated Show resolved Hide resolved
src/measure_theory/lp_space.lean Outdated Show resolved Hide resolved
src/measure_theory/lp_space.lean Outdated Show resolved Hide resolved
src/measure_theory/lp_space.lean Outdated Show resolved Hide resolved
src/measure_theory/lp_space.lean Outdated Show resolved Hide resolved
src/measure_theory/lp_space.lean Outdated Show resolved Hide resolved
src/measure_theory/lp_space.lean Outdated Show resolved Hide resolved
src/measure_theory/lp_space.lean Outdated Show resolved Hide resolved
src/analysis/special_functions/pow.lean Outdated Show resolved Hide resolved
@sgouezel sgouezel added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Nov 14, 2020
@bryangingechen
Copy link
Collaborator

Note that there are still 2 unaddressed comments that have been unhelpfully hidden from view by GitHub. You can see them if you click on "2 hidden comments", or by visiting the "Files Changed" tab above.

src/analysis/special_functions/pow.lean Outdated Show resolved Hide resolved
src/measure_theory/lp_space.lean Outdated Show resolved Hide resolved
src/measure_theory/lp_space.lean Outdated Show resolved Hide resolved
src/measure_theory/lp_space.lean Outdated Show resolved Hide resolved
@RemyDegenne RemyDegenne added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Nov 14, 2020
@sgouezel
Copy link
Collaborator

bors r+
Thanks!

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Nov 14, 2020
bors bot pushed a commit that referenced this pull request Nov 14, 2020
Define the space Lp of functions for which the norm raised to the power p has finite integral.
Define the seminorm on that space (without proof that it is a seminorm, for now).

Add three lemmas to analysis/special_functions/pow.lean about ennreal.rpow
<!--
put comments you want to keep out of the PR commit here.
If this PR depends on other PRs, please list them below this comment,
using the following format:
- [ ] depends on: #abc [optional extra text]
- [ ] depends on: #xyz [optional extra text]
-->
@bors
Copy link

bors bot commented Nov 14, 2020

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(measure_theory/lp_space): Define Lp spaces [Merged by Bors] - feat(measure_theory/lp_space): Define Lp spaces Nov 14, 2020
@bors bors bot closed this Nov 14, 2020
@bors bors bot deleted the Lp_spaces branch November 14, 2020 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants