Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(category_theory/commas): add simp-lemmas for comma categories #503

Merged
merged 4 commits into from Dec 15, 2018

Conversation

jcommelin
Copy link
Member

Add comma categories and basic functoriality properties

TO CONTRIBUTORS:

Make sure you have:

  • reviewed and applied the coding style: coding, naming
  • make sure definitions and lemmas are put in the right files
  • make sure definitions and lemmas are not redundant

For reviewers: code review check list

@rwbarton
Copy link
Collaborator

Much of this was already added in the limits-1 PR, though I renamed the module name to category_theory.comma because I find random pluralizations hard to remember.

@jcommelin jcommelin changed the title feat(category_theory/commas): add comma categories feat(category_theory/commas): add simp-lemmas for comma categories Nov 30, 2018
@semorrison
Copy link
Collaborator

I'm not sure I like the section names section simp and section map_left_and_right. At least, it's not the style used elsewhere in mathlib.

Perhaps remove these, or just change them to comments, e.g. section -- simp lemmas.

Perhaps @digama0 can give a style ruling, and we can update the style guide. :-)

@semorrison
Copy link
Collaborator

Other than that, looks good to me.

@jcommelin
Copy link
Member Author

Removed the section names.

@rwbarton
Copy link
Collaborator

LGTM... though it really shows how we need a better way to deal with this proliferation of simp lemmas.

@digama0 digama0 merged commit 28909a8 into leanprover-community:master Dec 15, 2018
@digama0 digama0 deleted the commas branch December 15, 2018 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants