[Merged by Bors] - chore(algebra/ordered_group): move monoid stuff to ordered_monoid.lean #5066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryangingechen
added
the
awaiting-review
kbuzzard
added
the
easy
bryangingechen
approved these changes
Nov 22, 2020
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Nov 22, 2020
#5066) Replace one 2000 line file with two 1000 line files: ordered group stuff in one, and ordered monoid stuff in the other.
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace one 2000 line file with two 1000 line files: ordered group stuff in one, and ordered monoid stuff in the other.
I want to add
linear_ordered_comm_monoid_with_zeroandlinear_ordered_comm_groupbut couldn't face editing a file which was already 2000 lines long (algebra/ordered_group.lean). This PR (hopefully) does nothing more than put the existing monoid stuff into one file and the group stuff into another.