[Merged by Bors] - fix(algebra/ordered_group): remove workaround #5103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eric-wieser
approved these changes
Nov 24, 2020
| /-- Alternative constructor for ordered commutative groups, | ||
| that avoids the field `mul_lt_mul_left`. -/ | ||
| @[to_additive "Alternative constructor for ordered commutative groups, | ||
| that avoids the field `mul_lt_mul_left`."] |
There was a problem hiding this comment.
This docstring was extra wrong - ordered_add_comm_group.mul_lt_mul_left never existed!
There was a problem hiding this comment.
Yes, the additive version of the docstring is incorrect.
github-actions
bot
added
the
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Nov 24, 2020
The problem mentioned in the TODO has been solved so the workaround is no longer needed.
|
bors crashed... let's try again |
bors bot
pushed a commit
that referenced
this pull request
Nov 25, 2020
The problem mentioned in the TODO has been solved so the workaround is no longer needed.
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem mentioned in the TODO has been solved so the workaround is no longer needed.
597704a#diff-ae21f2befcb736e64ce0312393429e5cadcc2d57fcc1e9f1d8d69587c17921ebL481-L491
was the solution, but the comment wasn't updated and the constructor is no longer really necessary.