Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore(category_theory/limits): separate regular and normal monos #5149

Closed
wants to merge 3 commits into from

Conversation

b-mehta
Copy link
Collaborator

@b-mehta b-mehta commented Nov 29, 2020

This separates the file regular_mono into regular_mono and normal_mono: mostly this simplifies the import graph, but also this has the advantage that to use things about kernel pairs it's no longer necessary to import things about zero objects (I kept changing equalizers and using the changes in a file about monads which imported kernel pairs, and it was very slow because of zero objects)

@b-mehta b-mehta added easy < 20s of review time. See the lifecycle page for guidelines. awaiting-review The author would like community review of the PR labels Nov 29, 2020
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Dec 1, 2020
bors bot pushed a commit that referenced this pull request Dec 1, 2020
This separates the file `regular_mono` into `regular_mono` and `normal_mono`: mostly this simplifies the import graph, but also this has the advantage that to use things about kernel pairs it's no longer necessary to import things about zero objects (I kept changing equalizers and using the changes in a file about monads which imported kernel pairs, and it was very slow because of zero objects)
@bors
Copy link

bors bot commented Dec 1, 2020

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request Dec 1, 2020
This separates the file `regular_mono` into `regular_mono` and `normal_mono`: mostly this simplifies the import graph, but also this has the advantage that to use things about kernel pairs it's no longer necessary to import things about zero objects (I kept changing equalizers and using the changes in a file about monads which imported kernel pairs, and it was very slow because of zero objects)
@bors
Copy link

bors bot commented Dec 2, 2020

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title chore(category_theory/limits): separate regular and normal monos [Merged by Bors] - chore(category_theory/limits): separate regular and normal monos Dec 2, 2020
@bors bors bot closed this Dec 2, 2020
@bors bors bot deleted the normal-mono branch December 2, 2020 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants