New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - refactor(*): Add _injective
alongside _inj
lemmas
#5150
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…njective` lemmas
eric-wieser
added
the
awaiting-review
The author would like community review of the PR
label
Nov 30, 2020
b-mehta
approved these changes
Nov 30, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
eric-wieser
added
the
easy
< 20s of review time. See the lifecycle page for guidelines.
label
Nov 30, 2020
jcommelin
approved these changes
Dec 1, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 🎉
bors merge
github-actions
bot
added
ready-to-merge
All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
and removed
awaiting-review
The author would like community review of the PR
labels
Dec 1, 2020
bors bot
pushed a commit
that referenced
this pull request
Dec 1, 2020
This adds four new `injective` lemmas: * `list.append_right_injective` * `list.append_left_injective` * `sub_right_injective` * `sub_left_injective` It also replaces as many `*_inj` lemmas as possible with an implementation of `*_injective.eq_iff`, to make it clear that the lemmas are just aliases of each other.
Build failed (retrying...): |
bors bot
pushed a commit
that referenced
this pull request
Dec 1, 2020
This adds four new `injective` lemmas: * `list.append_right_injective` * `list.append_left_injective` * `sub_right_injective` * `sub_left_injective` It also replaces as many `*_inj` lemmas as possible with an implementation of `*_injective.eq_iff`, to make it clear that the lemmas are just aliases of each other.
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
refactor(*): Add
[Merged by Bors] - refactor(*): Add Dec 2, 2020
_injective
alongside _inj
lemmas_injective
alongside _inj
lemmas
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
easy
< 20s of review time. See the lifecycle page for guidelines.
ready-to-merge
All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds four new
injective
lemmas:list.append_right_injective
list.append_left_injective
sub_right_injective
sub_left_injective
It also replaces as many
*_inj
lemmas as possible with an implementation of*_injective.eq_iff
, to make it clear that the lemmas are just aliases of each other.