Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - refactor(*): Add _injective alongside _inj lemmas #5150

Closed
wants to merge 4 commits into from

Conversation

eric-wieser
Copy link
Member

@eric-wieser eric-wieser commented Nov 29, 2020

This adds four new injective lemmas:

  • list.append_right_injective
  • list.append_left_injective
  • sub_right_injective
  • sub_left_injective

It also replaces as many *_inj lemmas as possible with an implementation of *_injective.eq_iff, to make it clear that the lemmas are just aliases of each other.


@eric-wieser eric-wieser added the awaiting-review The author would like community review of the PR label Nov 30, 2020
Copy link
Collaborator

@b-mehta b-mehta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@eric-wieser eric-wieser added the easy < 20s of review time. See the lifecycle page for guidelines. label Nov 30, 2020
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Dec 1, 2020
bors bot pushed a commit that referenced this pull request Dec 1, 2020
This adds four new `injective` lemmas:

* `list.append_right_injective`
* `list.append_left_injective`
* `sub_right_injective`
* `sub_left_injective`

It also replaces as many `*_inj` lemmas as possible with an implementation of `*_injective.eq_iff`, to make it clear that the lemmas are just aliases of each other.
@bors
Copy link

bors bot commented Dec 1, 2020

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request Dec 1, 2020
This adds four new `injective` lemmas:

* `list.append_right_injective`
* `list.append_left_injective`
* `sub_right_injective`
* `sub_left_injective`

It also replaces as many `*_inj` lemmas as possible with an implementation of `*_injective.eq_iff`, to make it clear that the lemmas are just aliases of each other.
@bors
Copy link

bors bot commented Dec 2, 2020

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title refactor(*): Add _injective alongside _inj lemmas [Merged by Bors] - refactor(*): Add _injective alongside _inj lemmas Dec 2, 2020
@bors bors bot closed this Dec 2, 2020
@bors bors bot deleted the eric-wieser/inj-injective branch December 2, 2020 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants