Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(ring_theory/polynomial/cyclotomic): Möbius inversion formula for cyclotomic polynomials #5192

Closed
wants to merge 4 commits into from
Closed

[Merged by Bors] - feat(ring_theory/polynomial/cyclotomic): Möbius inversion formula for cyclotomic polynomials #5192

wants to merge 4 commits into from

Conversation

awainverse
Copy link
Collaborator

Proves Möbius inversion for functions to a comm_group_with_zero
Proves the Möbius inversion formula for cyclotomic polynomials

@awainverse awainverse added the awaiting-review The author would like community review of the PR label Dec 2, 2020
@riccardobrasca
Copy link
Member

Looks good to me. I would add to the doc string that Möbius formula is purely formal, using the field of fraction of R[X] as abstract field, rather than rational functions (that are not in mathlib I think). For example we cannot use it to prove cyclotomic_coeff_zero.

@jcommelin jcommelin added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Dec 3, 2020
@awainverse awainverse added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Dec 3, 2020
@jcommelin
Copy link
Member

Thanks 🎉

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Dec 4, 2020
bors bot pushed a commit that referenced this pull request Dec 4, 2020
@awainverse
feat(ring_theory/polynomial/cyclotomic): Möbius inversion formula for…
4f5046d 
… cyclotomic polynomials (#5192)

Proves Möbius inversion for functions to a `comm_group_with_zero`
Proves the Möbius inversion formula for cyclotomic polynomials
@bors
Copy link

bors bot commented Dec 4, 2020

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(ring_theory/polynomial/cyclotomic): Möbius inversion formula for cyclotomic polynomials [Merged by Bors] - feat(ring_theory/polynomial/cyclotomic): Möbius inversion formula for cyclotomic polynomials Dec 4, 2020
@bors bors bot closed this Dec 4, 2020
@bors bors bot deleted the moebius_cyclotomic branch December 4, 2020 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@riccardobrasca riccardobrasca Awaiting requested review from riccardobrasca

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@awainverse @riccardobrasca @jcommelin